Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(587)

Issue 581400043: flower: Add boolean return value to 'Rational' class.

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by lemzwerg
Modified:
3 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

flower: Add boolean return value to 'Rational' class. This removes many clang warnings of the type implicit conversion turns floating-point number into integer: 'double' to 'bool' [-Wfloat-conversion]

Patch Set 1 #

Total comments: 1

Patch Set 2 : simplified #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M flower/include/rational.hh View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
dak
Frankly, I am disconcerted that the original code runs through a float conversion in the ...
3 months ago (2019-12-29 11:23:56 UTC) #1
lemzwerg
simplified
3 months ago (2019-12-29 11:52:25 UTC) #2
lemzwerg
3 months ago (2019-12-29 11:53:52 UTC) #3
Thanks for the review.  I agree with all your points.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b