Issue 5798074: gtk3: honor lookup table labels and orientation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5798074: gtk3: honor lookup table labels and orientation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by Daiki Ueno

Modified:
12 years, 1 month ago

Reviewers:
shawn.p.huang

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

gtk3: honor lookup table labels and orientation BUG=none TEST=manual

Patch Set 2 : minor coding style fixes #

Total comments: 4

Patch Set 3 : handle the case when labels are not set; honor system orientation #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -21 lines)			Patch
	M	ui/gtk3/candidatearea.vala	View	1 2	5 chunks	+13 lines, -20 lines	0 comments	Download
	M	ui/gtk3/candidatepanel.vala	View	1 2	4 chunks	+28 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

https://codereview.appspot.com/5798074/diff/2002/ui/gtk3/candidatearea.vala File ui/gtk3/candidatearea.vala (right): https://codereview.appspot.com/5798074/diff/2002/ui/gtk3/candidatearea.vala#newcode74 ui/gtk3/candidatearea.vala:74: m_labels[i].set_text(labels[i].get_text()); Maybe need set other labels to null if ...

12 years, 1 month ago (2012-03-13 15:03:23 UTC) #2

Daiki Ueno

12 years, 1 month ago (2012-03-14 01:58:32 UTC) #3

lgtm

Expand All Messages | Collapse All Messages