Issue 5796079: libibus: Fix a refcount issue in ibus_prop_list_deserialize()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5796079: libibus: Fix a refcount issue in ibus_prop_list_deserialize() (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by Peng

Modified:
12 years, 1 month ago

Reviewers:
yusukes, Yusuke Sato

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

libibus: Fix a refcount issue in ibus_prop_list_deserialize() BUG=None TEST=Linux desktop

Patch Set 1 #

Total comments: 1

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	src/ibusproplist.c	View		1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Peng

https://codereview.appspot.com/5796079/diff/1/src/ibusproplist.c File src/ibusproplist.c (left): https://codereview.appspot.com/5796079/diff/1/src/ibusproplist.c#oldcode111 src/ibusproplist.c:111: g_object_ref_sink (prop); ibus_prop_list_append() will call g_object_ref_sink(prop). So we have ...

12 years, 1 month ago (2012-03-13 15:45:13 UTC) #1

yusukes

12 years, 1 month ago (2012-03-13 16:02:59 UTC) #2

lgtm
On 2012/03/13 15:45:13, Peng wrote:
> https://codereview.appspot.com/5796079/diff/1/src/ibusproplist.c
> File src/ibusproplist.c (left):
> 
> https://codereview.appspot.com/5796079/diff/1/src/ibusproplist.c#oldcode111
> src/ibusproplist.c:111: g_object_ref_sink (prop);
> ibus_prop_list_append() will call g_object_ref_sink(prop). So we have to
remove
> g_object_ref_sink(prop) here.

Expand All Messages | Collapse All Messages