Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(48)

Issue 5796048: [PDF] Fix memory hungry inefficiency in pdf resource tracking. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by Steve VanDeBogart
Modified:
12 years, 6 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com, bungeman
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

[PDF] Fix memory hungry inefficiency in pdf resource tracking. When moving the content of a device into a PDF object like SkPDFFormXObject or SkPDFShader does, we only need the top level resources in the new object's resource list, not the recursive set of objects. Otherwise, when you put a form on a form on form, etc, references to the objects multiply. This fixed http://crbug.com/117321 Committed: https://code.google.com/p/skia/source/detail?r=3360

Patch Set 1 #

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -17 lines) Patch
M include/pdf/SkPDFDevice.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M include/pdf/SkPDFPage.h View 1 chunk +4 lines, -3 lines 0 comments Download
M include/pdf/SkPDFTypes.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 2 chunks +14 lines, -5 lines 0 comments Download
M src/pdf/SkPDFFormXObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFPage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFShader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Steve VanDeBogart
12 years, 6 months ago (2012-03-09 21:27:38 UTC) #1
reed1
12 years, 6 months ago (2012-03-09 22:06:45 UTC) #2
reed1
don't know enough of PDF at the high level to comment on the recursive-or-not nature ...
12 years, 6 months ago (2012-03-09 22:12:21 UTC) #3
Steve VanDeBogart
12 years, 6 months ago (2012-03-09 22:16:13 UTC) #4
On 2012/03/09 22:12:21, reed1 wrote:
> don't know enough of PDF at the high level to comment on the recursive-or-not
> nature of the change, but the code looks clean.

addResourcesToCatalog in SkPDFDocument is uniqueifying the list of resources
anyway, so this shouldn't change which objects are actually sent to the output
file.  It just reduces the duplicates in the list before that process.
 
> lgtm

Thanks
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b