Issue 5796044: Added assert for size.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5796044: Added assert for size.

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by Ali Afshar

Modified:
13 years, 10 months ago

Reviewers:
jcgregorio_google

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -18 lines)			Patch
	M	apiclient/http.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/test_http.py	View		2 chunks	+19 lines, -17 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Ali Afshar

Submitted in http://code.google.com/p/google-api-python-client/source/detail?r=7e4b0d56e5f4b14701c8cf71cf3192126c927013 On Mon, Mar 12, 2012 at 8:41 AM, <jcgregorio@google.com> wrote: > lgtm ...

13 years, 10 months ago (2012-03-12 13:18:33 UTC) #2

jcgregorio_google

For future reference please follow the guidelines for submitting code: http://code.google.com/p/google-api-python-client/wiki/BecomingAContributor#S... <http://code.google.com/p/google-api-python-client/wiki/BecomingAContributor#Submitting_Your_Approved_Code> Which includes adding ...

13 years, 10 months ago (2012-03-12 13:30:57 UTC) #3

Ali Afshar

13 years, 10 months ago (2012-03-12 13:50:19 UTC) #4

Yikes sorry! Thanks, will do.

On Mon, Mar 12, 2012 at 9:30 AM, Joe Gregorio <jcgregorio@google.com> wrote:

> For future reference please follow the guidelines for submitting code:
>
>  
http://code.google.com/p/google-api-python-client/wiki/BecomingAContributor#S...
<http://code.google.com/p/google-api-python-client/wiki/BecomingAContributor#S...>
>
> Which includes adding a reference to the codereview in the commit message.
>
>
>
> On Mon, Mar 12, 2012 at 9:18 AM, Ali Afshar <afshar@google.com> wrote:
>
>> Submitted in
>>
http://code.google.com/p/google-api-python-client/source/detail?r=7e4b0d56e5f...
>>
>> On Mon, Mar 12, 2012 at 8:41 AM, <jcgregorio@google.com> wrote:
>>
>>> lgtm
>>>
>>>
http://codereview.appspot.com/**5796044/<http://codereview.appspot.com/5796044/>
>>>
>>
>>
>>
>> --
>> Ali Afshar | www.googplus.org/ali | Google Developer Relations
>>
>>
>


-- 
Ali Afshar | www.googplus.org/ali | Google Developer Relations

Expand All Messages | Collapse All Messages