Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(22)

Issue 5795070: Increase test coverage. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by jcgregorio_google
Modified:
13 years, 3 months ago
CC:
google-api-python-client_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : 80 chars #

Total comments: 4

Patch Set 3 : updte #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -10 lines) Patch
M Makefile View 1 chunk +8 lines, -0 lines 0 comments Download
M oauth2client/appengine.py View 2 chunks +4 lines, -2 lines 0 comments Download
M oauth2client/client.py View 2 chunks +15 lines, -1 line 0 comments Download
M runtests.py View 1 chunk +4 lines, -3 lines 0 comments Download
A tests/data/client_secrets.json View 1 chunk +9 lines, -0 lines 0 comments Download
A tests/data/unfilled_client_secrets.json View 1 chunk +9 lines, -0 lines 0 comments Download
M tests/test_oauth2client.py View 5 chunks +24 lines, -0 lines 0 comments Download
M tests/test_oauth2client_appengine.py View 1 2 8 chunks +138 lines, -4 lines 0 comments Download

Messages

Total messages: 4
jcgregorio_google
13 years, 3 months ago (2012-03-13 12:28:54 UTC) #1
aiuto
lgtm What did the coverage go up to? http://codereview.appspot.com/5795070/diff/2001/tests/test_oauth2client_appengine.py File tests/test_oauth2client_appengine.py (right): http://codereview.appspot.com/5795070/diff/2001/tests/test_oauth2client_appengine.py#newcode67 tests/test_oauth2client_appengine.py:67: extra ...
13 years, 3 months ago (2012-03-13 20:31:41 UTC) #2
jcgregorio_google
Raised coverage of oauth2client.appengine from 75% to 94%. http://codereview.appspot.com/5795070/diff/2001/tests/test_oauth2client_appengine.py File tests/test_oauth2client_appengine.py (right): http://codereview.appspot.com/5795070/diff/2001/tests/test_oauth2client_appengine.py#newcode67 tests/test_oauth2client_appengine.py:67: On ...
13 years, 3 months ago (2012-03-14 04:07:39 UTC) #3
jcgregorio_google
13 years, 3 months ago (2012-03-14 04:10:57 UTC) #4

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b