Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4385)

Issue 579250043: Issue 5362: Generalize context searches (Take 2) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by Dan Eble
Modified:
4 years, 2 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5362/ 1: Add Context::matches () This method answers the central question of a context search: is this what I'm looking for? Its use will increase in later commits. 2: Generalize context searches Combine code for \new, \context, and various internal searches. This includes a small block of disabled code which will fix input/regression/context-find-parent.ly once it is enabled. input/regression/context-descend-only-not-found.ly shows that a defect in the descend-to-context function has been fixed: although the previous implementation never changed context outside the current subtree, it allowed creating a new context outside the current subtree. 3: Change descend-only to search-direction It is now a direction rather than a boolean. There was a previous review for this issue that had more stuff in it: https://codereview.appspot.com/344050043/

Patch Set 1 : Add Context::matches () #

Patch Set 2 : Generalize context searches #

Patch Set 3 : Change descend-only to search-direction #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -109 lines) Patch
A input/regression/context-descend-only-not-found.ly View 1 1 chunk +20 lines, -0 lines 0 comments Download
M lily/context.cc View 1 5 chunks +135 lines, -71 lines 0 comments Download
M lily/context-specced-music-iterator.cc View 1 2 3 chunks +13 lines, -10 lines 0 comments Download
M lily/include/context.hh View 1 5 chunks +62 lines, -22 lines 0 comments Download
M lily/quote-iterator.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M lily/simultaneous-music-iterator.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M scm/define-music-properties.scm View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M scm/music-functions.scm View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Dan Eble
Generalize context searches
4 years, 2 months ago (2020-01-29 20:40:11 UTC) #1
Dan Eble
Change descend-only to search-direction
4 years, 2 months ago (2020-01-29 20:40:44 UTC) #2
Dan Eble
4 years, 2 months ago (2020-01-29 20:43:44 UTC) #3

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b