lily/fretboard-engraver.cc - Issue 579240043: Issue 4550: Avoid "using namespace std;" in included files (Take 2)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lily/fretboard-engraver.cc

Issue 579240043: Issue 4550: Avoid "using namespace std;" in included files (Take 2) (Closed)

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: lily/fretboard-engraver.cc

diff --git a/lily/fretboard-engraver.cc b/lily/fretboard-engraver.cc

index f0087c42d0967e373bdbf66d8f5552d5abb3efbc..0b0734ae15226cd0c7200441d6c8a7beab1287cc 100644

--- a/lily/fretboard-engraver.cc

+++ b/lily/fretboard-engraver.cc

@@ -19,7 +19,6 @@

#include <cctype>

#include <cstdio>

-using namespace std;

#include "articulations.hh"

#include "context.hh"

@@ -31,6 +30,8 @@ using namespace std;

#include "translator.icc"

+using std::vector;

/**

make (guitar-like) tablature note