code review 5788043: misc/cgo: re-enable testso

misc/cgo: re-enable testso

The test.bash file generates .so file using gcc, builds the executable
using the go tool and then run it with the $LD_LIBRARY_PATH variable
pointing to the directory where the .so file lives.

Fixes issue 2982.

[fss, 2012-03-08 01:07:09]

Hello rsc@golang.org, remyoudompheng@gmail.com (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2012-03-08 04:19:42]

Thanks for working on this.

I think the file movement can be avoided
Please try the following, which is more like
what the other cgo directories do:

1. Put files back in one directory.2
2. Insert // +build ignore at the top of the .c file
  (after the copyright).
3. Insert // +build ignore at the top of the main.go file
  (after the copyright).
4. Change main.go to say import "." instead of import "./cgosotest"
5. Merge the two gcc commands in test.bash:
  gcc -fPIC -g -c -shared -o libcgosotest.so cgoso_c.c
6. Change test.bash's go build to say 'go build main.go'
and then run as ./main.

Also please change the CL description to say

Fixes issue 2982.

since this is the last one for that issue.

Thanks again.
Russ

[fss, 2012-03-08 04:40:54]

Hello rsc@golang.org, remyoudompheng@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[fss, 2012-03-08 04:41:00]

On Thu, Mar 8, 2012 at 1:19 AM, Russ Cox <rsc@golang.org> wrote:

> Thanks for working on this.
>
> I think the file movement can be avoided
>

I wanted to avoid it, but I didn't notice the build tags, thank you! :)

-- 
Francisco Souza

[fss, 2012-03-08 04:43:00]

Ops, cgoso.go and cgoso_c.c still showing as removed.

Fixing it.

[fss, 2012-03-08 04:44:05]

Hello rsc@golang.org, remyoudompheng@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-03-08 04:59:09]

Thanks, very nice.

Please remove go clean from test.bash
and instead add main to the rm -f line.

Also, please insert a blank line between the
copyright note and the +build comment
in the two files.

[fss, 2012-03-08 05:14:16]

Hello rsc@golang.org, remyoudompheng@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[fss, 2012-03-08 14:54:45]

ping?

On Thu, Mar 8, 2012 at 2:14 AM, <franciscossouza@gmail.com> wrote:

> Hello rsc@golang.org, remyoudompheng@gmail.com (cc:
> golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
http://codereview.appspot.com/**5788043/<http://codereview.appspot.com/5788043/>
>



-- 
Francisco Souza

[rsc, 2012-03-08 15:37:30]

LGTM

[rsc, 2012-03-08 17:13:44]

*** Submitted as http://code.google.com/p/go/source/detail?r=c053986a1184 ***

misc/cgo: re-enable testso

The test.bash file generates .so file using gcc, builds the executable
using the go tool and then run it with the $LD_LIBRARY_PATH variable
pointing to the directory where the .so file lives.

Fixes issue 2982.

R=rsc, remyoudompheng
CC=golang-dev
http://codereview.appspot.com/5788043

Committer: Russ Cox <rsc@golang.org>