CPP: libphonenumber 4.6.

CPP: libphonenumber 4.6.

Note that the metadata files were not uploaded to appspot because they were too
large. Here is the list of the files affected by this change (generated by
Git):

cpp/src/phonenumbers/lite_metadata.cc
cpp/src/phonenumbers/logger.h
cpp/src/phonenumbers/metadata.cc
cpp/src/phonenumbers/phonenumbermatcher.cc
cpp/src/phonenumbers/phonenumberutil.cc
cpp/src/phonenumbers/phonenumberutil.h
cpp/src/phonenumbers/region_code.h
cpp/src/phonenumbers/stringutil.cc
cpp/src/phonenumbers/stringutil.h
cpp/test/phonenumbers/asyoutypeformatter_test.cc
cpp/test/phonenumbers/phonenumbermatcher_test.cc
cpp/test/phonenumbers/phonenumberutil_test.cc
cpp/test/phonenumbers/stringutil_test.cc

This CL also fixes the issue reported by Aaron about the logger being invoked
before it is initialized.

Committed: https://code.google.com/p/libphonenumber/source/detail?r=430

[lararennie, 2012-03-13 17:23:03]

Thank you!

http://codereview.appspot.com/5786065/diff/1/cpp/src/phonenumbers/region_code.h
File cpp/src/phonenumbers/region_code.h (right):

http://codereview.appspot.com/5786065/diff/1/cpp/src/phonenumbers/region_code...
cpp/src/phonenumbers/region_code.h:29: return "ZZ";
Perhaps we could return ZZ() instead :)

http://codereview.appspot.com/5786065/diff/1/cpp/test/phonenumbers/stringutil...
File cpp/test/phonenumbers/stringutil_test.cc (right):

http://codereview.appspot.com/5786065/diff/1/cpp/test/phonenumbers/stringutil...
cpp/test/phonenumbers/stringutil_test.cc:290: s = "abc";
You could also just set s to "a" each time? or clear it? It is a bit random how
you set it to the old value every time? Or otherwise not reassign, and do
ASSERT_EQ instead?

[lararennie, 2012-03-13 17:23:15]

Oh, and LGTM :)

[philippe, 2012-03-14 14:28:19]

Thanks Lara for the quick review :)

http://codereview.appspot.com/5786065/diff/1/cpp/src/phonenumbers/region_code.h
File cpp/src/phonenumbers/region_code.h (right):

http://codereview.appspot.com/5786065/diff/1/cpp/src/phonenumbers/region_code...
cpp/src/phonenumbers/region_code.h:29: return "ZZ";
On 2012/03/13 17:23:04, lararennie wrote:
> Perhaps we could return ZZ() instead :)

Done.

http://codereview.appspot.com/5786065/diff/1/cpp/test/phonenumbers/stringutil...
File cpp/test/phonenumbers/stringutil_test.cc (right):

http://codereview.appspot.com/5786065/diff/1/cpp/test/phonenumbers/stringutil...
cpp/test/phonenumbers/stringutil_test.cc:290: s = "abc";
On 2012/03/13 17:23:04, lararennie wrote:
> You could also just set s to "a" each time? or clear it? It is a bit random
how
> you set it to the old value every time? Or otherwise not reassign, and do
> ASSERT_EQ instead?

Done.

[lararennie, 2012-03-15 15:53:44]

Still looks fine.

[pliard, 2012-03-15 16:40:36]

I am waiting for Shaopeng's LGTM :)

On Thu, Mar 15, 2012 at 4:53 PM, <lararennie@google.com> wrote:

> Still looks fine.
>
>
http://codereview.appspot.com/**5786065/<http://codereview.appspot.com/5786065/>
>

[lararennie, 2012-03-15 16:49:04]

In future, I think you should just submit when you get them from one
of us, either is fine :)

2012/3/15 Philippe Liard <pliard@google.com>:
> I am waiting for Shaopeng's LGTM :)
>
>
> On Thu, Mar 15, 2012 at 4:53 PM, <lararennie@google.com> wrote:
>>
>> Still looks fine.
>>
>> http://codereview.appspot.com/5786065/
>
>

[pliard, 2012-03-15 16:58:40]

That's also what I thought :) I just wanted to be sure. I will submit that
now, thanks.

On Thu, Mar 15, 2012 at 5:48 PM, Lara Rennie <lararennie@google.com> wrote:

> In future, I think you should just submit when you get them from one
> of us, either is fine :)
>
> 2012/3/15 Philippe Liard <pliard@google.com>:
> > I am waiting for Shaopeng's LGTM :)
> >
> >
> > On Thu, Mar 15, 2012 at 4:53 PM, <lararennie@google.com> wrote:
> >>
> >> Still looks fine.
> >>
> >> http://codereview.appspot.com/5786065/
> >
> >
>

[shaopengjia, 2012-03-15 17:36:28]

Ditto what Lara said.

It is cool that Philippe got an email that ends with chromium.org :-) I
applied for one ending with android.org a couple of years ago, but still
haven't gotten it...

On Thu, Mar 15, 2012 at 5:58 PM, Philippe Liard <pliard@google.com> wrote:

> That's also what I thought :) I just wanted to be sure. I will submit that
> now, thanks.
>
>
> On Thu, Mar 15, 2012 at 5:48 PM, Lara Rennie <lararennie@google.com>wrote:
>
>> In future, I think you should just submit when you get them from one
>> of us, either is fine :)
>>
>> 2012/3/15 Philippe Liard <pliard@google.com>:
>> > I am waiting for Shaopeng's LGTM :)
>> >
>> >
>> > On Thu, Mar 15, 2012 at 4:53 PM, <lararennie@google.com> wrote:
>> >>
>> >> Still looks fine.
>> >>
>> >> http://codereview.appspot.com/5786065/
>> >
>> >
>>
>
>


-- 
Shaopeng Jia
贾少鹏
Senior Software Engineer - Îñţérñåţîöñåļîžåţîöñ
Google Switzerland GmbH |Identifikationsnummer: CH-020.4.028.116-1

[pliard, 2012-03-15 17:44:26]

Yes I like my new @chromium.org e-mail address. From what you told me, I'm
not surprised for your Android request :)

On Thu, Mar 15, 2012 at 6:36 PM, Shaopeng Jia (贾少鹏)
<shaopengjia@google.com>wrote:

> Ditto what Lara said.
>
> It is cool that Philippe got an email that ends with chromium.org :-) I
> applied for one ending with android.org a couple of years ago, but still
> haven't gotten it...
>
>
> On Thu, Mar 15, 2012 at 5:58 PM, Philippe Liard <pliard@google.com> wrote:
>
>> That's also what I thought :) I just wanted to be sure. I will submit
>> that now, thanks.
>>
>>
>> On Thu, Mar 15, 2012 at 5:48 PM, Lara Rennie <lararennie@google.com>wrote:
>>
>>> In future, I think you should just submit when you get them from one
>>> of us, either is fine :)
>>>
>>> 2012/3/15 Philippe Liard <pliard@google.com>:
>>> > I am waiting for Shaopeng's LGTM :)
>>> >
>>> >
>>> > On Thu, Mar 15, 2012 at 4:53 PM, <lararennie@google.com> wrote:
>>> >>
>>> >> Still looks fine.
>>> >>
>>> >> http://codereview.appspot.com/5786065/
>>> >
>>> >
>>>
>>
>>
>
>
> --
> Shaopeng Jia
> 贾少鹏
> Senior Software Engineer - Îñţérñåţîöñåļîžåţîöñ
> Google Switzerland GmbH |Identifikationsnummer: CH-020.4.028.116-1
>