Issue 5783092: code review 5783092: os: remove document duplication in error predicate functions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5783092: code review 5783092: os: remove document duplication in error predicate functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by minux1

Modified:
13 years ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

os: remove document duplication in error predicate functions

Patch Set 1 #

Patch Set 2 : diff -r 65ab6c67373a https://code.google.com/p/go/ #

Patch Set 3 : diff -r 162b42fd9e57 https://code.google.com/p/go/ #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -24 lines)			Patch
M	src/pkg/os/error.go	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
M	src/pkg/os/error_plan9.go	View	1	1 chunk	+3 lines, -6 lines	0 comments	Download
M	src/pkg/os/error_posix.go	View	1	1 chunk	+3 lines, -9 lines	0 comments	Download
M	src/pkg/os/error_windows.go	View	1	2 chunks	+3 lines, -9 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years ago (2012-03-13 05:30:31 UTC) #1

minux1

One remaining question: Should IsNotExist returns true when it is a *directory* that does not ...

13 years ago (2012-03-13 05:35:16 UTC) #2

LGTM do the semantic change in a separate CL. i agree with it, if only ...

13 years ago (2012-03-13 05:43:55 UTC) #3

minux1

13 years ago (2012-03-13 05:48:17 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=425491751164 ***

os: remove document duplication in error predicate functions

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5783092

Expand All Messages | Collapse All Messages