src/cmd/gc/walk.c - Issue 5783047: code review 5783047: cmd/gc: delete old map delete in walk

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/cmd/gc/walk.c

Issue 5783047: code review 5783047: cmd/gc: delete old map delete in walk (Closed)

Patch Set: diff -r 79896e3bc1f8 https://code.google.com/p/go/ Created 13 years ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/cmd/gc/walk.c

===================================================================

--- a/src/cmd/gc/walk.c

+++ b/src/cmd/gc/walk.c

@@ -646,12 +646,6 @@

n->ninit = nil;

l = n->list->n;

r = n->list->next->n;

- if(n->right != N) {

- // TODO: Remove once two-element map assigment is gone.

- l = safeexpr(l, init);

- r = safeexpr(r, init);

- safeexpr(n->right, init); // cause side effects from n->right

- }

t = l->type;

n = mkcall1(mapfndel("mapdelete", t), t->down, init, typename(t), l, r);

goto ret;

« no previous file with comments | « no previous file | no next file » | no next file with comments »