Issue 578042: code review 578042: godoc: initial support for showing popup information

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 578042: code review 578042: godoc: initial support for showing popup information (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by gri

Modified:
14 years, 2 months ago

Reviewers:
adg

CC:
rsc, golang-dev

Visibility:
Public.

Description

godoc: initial support for showing popup information for identifiers in Go source code - at the moment just show identifier kind (var, func, etc.) and name (eventually should show declaration, type, etc.) - JavaScript parts by adg

Patch Set 1 #

Patch Set 2 : code review 578042: godoc: initial support for showing popup information #

Patch Set 3 : code review 578042: godoc: initial support for showing popup information #

Total comments: 2

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -6 lines)			Patch
A	doc/popups.js	View	1	1 chunk	+24 lines, -0 lines	1 comment	Download
M	doc/style.css	View		1 chunk	+13 lines, -0 lines	0 comments	Download
A	lib/godoc/source.html	View		1 chunk	+23 lines, -0 lines	1 comment	Download
M	src/cmd/godoc/godoc.go	View	1	7 chunks	+65 lines, -6 lines	0 comments	Download
M	src/pkg/go/ast/scope.go	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: adg, golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 2 months ago (2010-03-16 18:56:55 UTC) #1

gri

http://uetli:6666/src/pkg/compress/zlib/writer.go On Tue, Mar 16, 2010 at 2:02 PM, <rsc@golang.org> wrote: > demo? > > ...

14 years, 2 months ago (2010-03-16 21:15:08 UTC) #3

gri

*** Submitted as http://code.google.com/p/go/source/detail?r=a8faa8591ccf *** godoc: initial support for showing popup information for identifiers in ...

14 years, 2 months ago (2010-03-16 21:17:45 UTC) #5

adg

14 years, 2 months ago (2010-03-16 23:48:09 UTC) #6

Dates are wrong, no big deal though.

http://codereview.appspot.com/578042/diff/11001/12001
File doc/popups.js (right):

http://codereview.appspot.com/578042/diff/11001/12001#newcode1
doc/popups.js:1: // Copyright 2009 The Go Authors. All rights reserved.
This should be 2010.

http://codereview.appspot.com/578042/diff/11001/12003
File lib/godoc/source.html (right):

http://codereview.appspot.com/578042/diff/11001/12003#newcode2
lib/godoc/source.html:2: Copyright 2009 The Go Authors. All rights reserved.
2010

Expand All Messages | Collapse All Messages