Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2023)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 577840051: Put system headers after lilypond headers throughout (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by hanwenn
Modified:
5 years ago
Reviewers:
hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Put system headers after lilypond headers throughout

Patch Set 1 #

Patch Set 2 : revert pango-font.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -205 lines) Patch
M lily/accidental-placement.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/audio-element.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/axis-group-interface.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/bar-number-engraver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/book.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/break-substitution.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M lily/clef-engraver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/completion-note-heads-engraver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/completion-rest-engraver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/cue-clef-engraver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/custos.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/dot-column.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M lily/drum-note-engraver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/dynamic-align-engraver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/file-name-map.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M lily/font-config.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M lily/font-metric.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M lily/fretboard-engraver.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M lily/function-documentation.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/general-scheme.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M lily/global-context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/grob.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M lily/grob-property.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/includable-lexer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/input.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/ledger-line-spanner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/lily-guile.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M lily/lily-lexer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/lily-parser-scheme.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/lilypond-version.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/lookup.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/main.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M lily/mark-engraver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/metronome-engraver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/midi-stream.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M lily/modified-font-metric.cc View 2 chunks +2 lines, -1 line 0 comments Download
M lily/music-iterator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/note-column.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/note-head.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M lily/note-heads-engraver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/one-line-auto-height-breaking.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/one-line-page-breaking.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/open-type-font.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/open-type-font-scheme.cc View 2 chunks +2 lines, -1 line 0 comments Download
M lily/page-spacing-result.cc View 1 chunk +1 line, -0 lines 0 comments Download
M lily/pango-font-scheme.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/paper-outputter.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/parse-scm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/pdf-scheme.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/performance.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/pfb.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M lily/program-option-scheme.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/pure-from-neighbor-engraver.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/relocate.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M lily/rest-collision.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M lily/rest-collision-engraver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/side-position-interface.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M lily/simple-spacer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/simple-spacer-scheme.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/skyline.cc View 1 chunk +1 line, -0 lines 0 comments Download
M lily/source-file.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M lily/spaceable-grob.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M lily/spacing-spanner.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M lily/span-bar-stub-engraver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/staff-performer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/staff-spacing.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/stem.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/stream-event.cc View 1 chunk +1 line, -0 lines 0 comments Download
M lily/system.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/system-start-delimiter-engraver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/tab-note-heads-engraver.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M lily/tab-tie-follow-engraver.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/tie-column.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M lily/tie-performer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M lily/ttf.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/volta-bracket.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
hahnjo
LGTM, thanks for going through all files! (I didn't review every single file)
5 years ago (2020-04-27 08:26:43 UTC) #1
hanwenn
revert pango-font.cc
5 years ago (2020-04-27 21:33:05 UTC) #2
hanwenn
5 years ago (2020-05-02 22:23:53 UTC) #3 
commit b96b6334c00adb398b632aaeefdeaf3a8e6c57c5
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Mon Apr 27 10:22:26 2020 +0200

    Put system headers after lilypond headers throughou
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b