Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1147)

Issue 577700045: Cleanup flower/ makefile (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 3 weeks ago by hanwenn
Modified:
3 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Cleanup flower/ makefile * Inline library stepmake template * Inline test stepmake template * Drop unused declarations

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -26 lines) Patch
M flower/GNUmakefile View 1 chunk +34 lines, -4 lines 2 comments Download
D stepmake/stepmake/library-rules.make View 1 chunk +0 lines, -11 lines 0 comments Download
D stepmake/stepmake/library-targets.make View 1 chunk +0 lines, -3 lines 0 comments Download
D stepmake/stepmake/library-vars.make View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 2
lemzwerg
LGTM, with nits. https://codereview.appspot.com/577700045/diff/547810068/flower/GNUmakefile File flower/GNUmakefile (right): https://codereview.appspot.com/577700045/diff/547810068/flower/GNUmakefile#newcode17 flower/GNUmakefile:17: TEST_LOADLIBES = $(LIBRARY) $(CXXABI_LIBS) I suggest ...
3 months, 3 weeks ago (2020-03-22 06:13:21 UTC) #1
hanwenn
3 months ago (2020-04-09 17:28:53 UTC) #2
commit 719b9352fd8f3fb0a904ba7cfde402d8352e0eac
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Sat Mar 21 23:37:34 2020 +0100

    Cleanup flower/ makefile
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b