Issue 577700045: Cleanup flower/ makefile

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 577700045: Cleanup flower/ makefile (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years ago by hanwenn

Modified:
4 years ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Cleanup flower/ makefile * Inline library stepmake template * Inline test stepmake template * Drop unused declarations

Patch Set 1 #

Total comments: 2

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -26 lines)			Patch
M	flower/GNUmakefile	View	1 chunk	+34 lines, -4 lines	2 comments	Download
D	stepmake/stepmake/library-rules.make	View	1 chunk	+0 lines, -11 lines	0 comments	Download
D	stepmake/stepmake/library-targets.make	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	stepmake/stepmake/library-vars.make	View	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lemzwerg

LGTM, with nits. https://codereview.appspot.com/577700045/diff/547810068/flower/GNUmakefile File flower/GNUmakefile (right): https://codereview.appspot.com/577700045/diff/547810068/flower/GNUmakefile#newcode17 flower/GNUmakefile:17: TEST_LOADLIBES = $(LIBRARY) $(CXXABI_LIBS) I suggest ...

4 years ago (2020-03-22 06:13:21 UTC) #1

hanwenn

4 years ago (2020-04-09 17:28:53 UTC) #2

commit 719b9352fd8f3fb0a904ba7cfde402d8352e0eac
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Sat Mar 21 23:37:34 2020 +0100

    Cleanup flower/ makefile

Expand All Messages | Collapse All Messages