Some notes and potential issues: 1. I have not made gyp changes to actually BUILD ...
12 years, 9 months ago
(2012-03-07 17:15:38 UTC)
#2
Some notes and potential issues:
1. I have not made gyp changes to actually BUILD libjpeg as part of any of our
existing targets. For now, I have just imported the libjpeg source code.
2. The libjpeg source we import is maintained within the chromium source tree.
3. I have pinned the dependency at the current chromium tip-of-tree. If/when
chromium modifies its libjpeg source, the libjpeg source that chromium builds
against will be different than the libjpeg source that Skia builds against.
4. When chromium imports the Skia code, it will not in turn import libjpeg or
other third_party code that Skia has as an external dependency. I guess when
Skia is built as part of chromium it will be built against chromium's libjpeg
source, but when Skia is built on its own it will be built against the pinned
rev imported into third_party/externals.
I'm sure this is confusing, Rob; we will discuss it live.
Issue 5773043: Add libjpeg source as third_party/externals dependency
(Closed)
Created 12 years, 9 months ago by epoger
Modified 12 years, 9 months ago
Reviewers: DerekS
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0