Issue 5772044: use higher precision (64bit) fixed-point for matrix proc

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5772044: use higher precision (64bit) fixed-point for matrix proc (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by reed1

Modified:
12 years, 4 months ago

Reviewers:
caryclark1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

use higher precision (64bit) fixed-point for matrix proc Committed: https://code.google.com/p/skia/source/detail?r=3336

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+159 lines, -20 lines)			Patch
A	gm/giantbitmap.cpp	View	1 2 3	1 chunk	+103 lines, -0 lines	0 comments	Download
M	gyp/gmslides.gypi	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/core/SkFixed.h	View	1 2 3	1 chunk	+16 lines, -0 lines	0 comments	Download
M	src/core/SkBitmapProcState.h	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download
M	src/core/SkBitmapProcState.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/core/SkBitmapProcState_matrix.h	View	1 2	5 chunks	+22 lines, -20 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

reed1

... still to add the gm/test to confirm that this fixes the original bug

12 years, 4 months ago (2012-03-07 19:03:03 UTC) #1

caryclark1

12 years, 4 months ago (2012-03-07 20:02:53 UTC) #2

lgtm

https://codereview.appspot.com/5772044/diff/5001/include/core/SkFixed.h
File include/core/SkFixed.h (right):

https://codereview.appspot.com/5772044/diff/5001/include/core/SkFixed.h#newco...
include/core/SkFixed.h:275: #define SkFloatToFixed48(x)     ((SkFixed48)((x) *
(65536.0 * 65536.0 * 65536.0)))
would 65536.0f trigger a float vs a double multiply? Maybe there's no
difference.

Expand All Messages | Collapse All Messages