code review 5759064: build: re-enable remaining broken tests in run.bash

build: re-enable some broken tests in run.bash
        Updates issue 2982.

[minux1, 2012-03-07 06:18:08]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[rsc1, 2012-03-07 06:24:09]

http://codereview.appspot.com/5759064/diff/2002/src/run.bash
File src/run.bash (right):

http://codereview.appspot.com/5759064/diff/2002/src/run.bash#newcode73
src/run.bash:73: for i in ../misc/dashboard/builder ../misc/goplay
Does it work to do:

echo
echo '#' ../misc
go build ../misc/dashboard/builder ../misc/goplay

?

http://codereview.appspot.com/5759064/diff/2002/src/run.bash#newcode85
src/run.bash:85: (xcd ../test/bench/go1
Does it work to do

echo
echo '#' ../test/bench/go1
go test ../test/bench/go1

[minux1, 2012-03-07 06:38:56]

PTAL.
On 2012/03/07 06:24:09, rsc1 wrote:
> http://codereview.appspot.com/5759064/diff/2002/src/run.bash#newcode73
> src/run.bash:73: for i in ../misc/dashboard/builder ../misc/goplay
> Does it work to do:
> 
> echo
> echo '#' ../misc
> go build ../misc/dashboard/builder ../misc/goplay
It does work, with one added benefit, it only test the build, won't leave the
resulting
binary around.

> http://codereview.appspot.com/5759064/diff/2002/src/run.bash#newcode85
> src/run.bash:85: (xcd ../test/bench/go1
> Does it work to do
> 
> echo
> echo '#' ../test/bench/go1
> go test ../test/bench/go1
This also works.

[rsc1, 2012-03-07 15:21:01]

LGTM

But please hg sync, test all.bash again, and
remove the "Fixes issue" line.  We still have testso.

[minux1, 2012-03-07 22:24:04]

*** Submitted as http://code.google.com/p/go/source/detail?r=c0d04c84d692 ***

build: re-enable some broken tests in run.bash
        Updates issue 2982.

R=rsc, rsc
CC=golang-dev
http://codereview.appspot.com/5759064