Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(717)

Issue 575860044: aclocal.m4: Support GUILE_CONFIG, document GUILE_FLAVOR

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 3 weeks ago by dak
Modified:
3 months, 3 weeks ago
Reviewers:
lemzwerg, hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

aclocal.m4: Support GUILE_CONFIG, document GUILE_FLAVOR While this is rather rudimentary support and does not obviate the need to fix INSTALL.txt, it should give enough of a clue to people using ./configure --help to get things going. Also settings of GUILE_FLAVOR and GUILE_CONFIG from the environment are preserved for the sake of ./config.status --recheck .

Patch Set 1 #

Patch Set 2 : Untabify #

Total comments: 5

Patch Set 3 : Formatting and ;; #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M aclocal.m4 View 1 2 3 chunks +36 lines, -2 lines 0 comments Download

Messages

Total messages: 7
hahnjo
Generally looks fine to me, you only might want to revisit indention: aclocal.m4 uses 4 ...
3 months, 3 weeks ago (2020-03-20 14:54:36 UTC) #1
dak
Untabify
3 months, 3 weeks ago (2020-03-20 15:04:26 UTC) #2
dak
On 2020/03/20 14:54:36, hahnjo wrote: > Generally looks fine to me, you only might want ...
3 months, 3 weeks ago (2020-03-20 15:05:44 UTC) #3
hahnjo
LGTM
3 months, 3 weeks ago (2020-03-20 15:09:36 UTC) #4
lemzwerg
LGTM, and some minor nits. https://codereview.appspot.com/575860044/diff/547790043/aclocal.m4 File aclocal.m4 (right): https://codereview.appspot.com/575860044/diff/547790043/aclocal.m4#newcode625 aclocal.m4:625: AC_ARG_VAR(GUILE_FLAVOR, AS_HELP_STRING([], What about ...
3 months, 3 weeks ago (2020-03-21 05:41:06 UTC) #5
dak
https://codereview.appspot.com/575860044/diff/547790043/aclocal.m4 File aclocal.m4 (right): https://codereview.appspot.com/575860044/diff/547790043/aclocal.m4#newcode625 aclocal.m4:625: AC_ARG_VAR(GUILE_FLAVOR, AS_HELP_STRING([], On 2020/03/21 05:41:05, lemzwerg wrote: > What ...
3 months, 3 weeks ago (2020-03-21 08:43:56 UTC) #6
dak
3 months, 3 weeks ago (2020-03-21 08:51:17 UTC) #7
Formatting and ;;
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b