Issue 5758060: code review 5758060: libgo: Implement and use runtime.Caller, runtime.Func.F...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5758060: code review 5758060: libgo: Implement and use runtime.Caller, runtime.Func.F... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by iant

Modified:
13 years ago

Reviewers:

CC:
iant, gofrontend-dev_googlegroups.com

Visibility:
Public.

Description

libgo: Implement and use runtime.Caller, runtime.Func.FileLine.

Patch Set 1 #

Patch Set 2 : diff -r 5f7b1adc8ca1 https://gofrontend.googlecode.com/hg/ #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+861 lines, -68 lines)			Patch
M	libgo/Makefile.am	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	libgo/Makefile.in	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	libgo/go/debug/dwarf/const.go	View		1 chunk	+27 lines, -0 lines	0 comments	Download
M	libgo/go/debug/dwarf/entry.go	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	libgo/go/debug/dwarf/line.go	View		1 chunk	+416 lines, -0 lines	0 comments	Download
A	libgo/go/debug/dwarf/line_test.go	View		1 chunk	+53 lines, -0 lines	0 comments	Download
M	libgo/go/debug/dwarf/unit.go	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	libgo/go/debug/elf/elf_test.go	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	libgo/go/debug/elf/file.go	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	libgo/go/debug/elf/file_test.go	View		1 chunk	+2 lines, -1 line	0 comments	Download
A	libgo/go/debug/elf/runtime.go	View	1	1 chunk	+161 lines, -0 lines	0 comments	Download
M	libgo/go/debug/macho/file.go	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	libgo/go/debug/macho/file_test.go	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	libgo/go/encoding/binary/binary_test.go	View		2 chunks	+3 lines, -2 lines	0 comments	Download
A	libgo/go/encoding/binary/export_test.go	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	libgo/go/encoding/binary/varint_test.go	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	libgo/go/log/log.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	libgo/go/log/log_test.go	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	libgo/go/net/http/pprof/pprof.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	libgo/go/net/ip_test.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	libgo/go/runtime/debug/stack.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	libgo/go/runtime/extern.go	View	1	2 chunks	+6 lines, -10 lines	0 comments	Download
M	libgo/go/runtime/pprof/pprof.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	libgo/go/testing/testing.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	libgo/runtime/go-caller.c	View		2 chunks	+110 lines, -15 lines	0 comments	Download
M	libgo/runtime/go-callers.c	View		3 chunks	+11 lines, -1 line	0 comments	Download
M	libgo/runtime/mprof.goc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	libgo/runtime/runtime.h	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	libgo/runtime/runtime.c	View		1 chunk	+0 lines, -19 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

iant

Hello iant@golang.org (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://gofrontend.googlecode.com/hg/

13 years ago (2012-03-07 01:06:42 UTC) #1

iant

13 years ago (2012-03-07 01:06:52 UTC) #2

*** Submitted as
http://code.google.com/p/gofrontend/source/detail?r=e9c1caae3b22 ***

libgo: Implement and use runtime.Caller, runtime.Func.FileLine.

R=iant
CC=gofrontend-dev
http://codereview.appspot.com/5758060

Expand All Messages | Collapse All Messages