Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(929)

Issue 575750043: stepmake: use patsubst for finding build-dir (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by hanwenn
Modified:
3 months, 3 weeks ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

stepmake: use patsubst for finding build-dir The previous approach used $(subst ) which replaces all occurrences. This lead to surprising results when the top-build-dir was called /lilypond, as it is in the Docker builds.

Patch Set 1 #

Patch Set 2 : separate builddir #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M stepmake/stepmake/generic-vars.make View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
hanwenn
separate builddir
4 months, 1 week ago (2020-03-03 20:11:07 UTC) #1
hanwenn
3 months, 3 weeks ago (2020-03-15 15:34:57 UTC) #2
commit febe487bb45c97f97377536a5d15da80cce80297
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Sun Mar 1 14:03:36 2020 +0100

    stepmake: use patsubst for finding build-dir
    
    The previous approach used $(subst ) which replaces all occurrences.
    This lead to surprising results when the top-build-dir was called
    /lilypond, as it is in the Docker builds.
    
    https://sourceforge.net/p/testlilyissues/issues/5814
    http://codereview.appspot.com/575750043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b