Issue 5756061: Remove some unused code.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5756061: Remove some unused code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by Peng

Modified:
12 years, 8 months ago

Reviewers:
fujiwara

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Remove some unused code. BUG=None TEST=Make

Patch Set 1 #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -191 lines)			Patch
M	bus/ibusimpl.c	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	client/x11/gdk-private.c	View	3 chunks	+0 lines, -64 lines	0 comments	Download
M	src/ibuscomponent.c	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	src/ibusconfigservice.c	View	3 chunks	+0 lines, -41 lines	0 comments	Download
M	src/ibusshare.c	View	1 chunk	+0 lines, -51 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

fujiwara

12 years, 8 months ago (2012-03-07 02:02:46 UTC) #2

On 2012/03/06 20:21:07, Peng wrote:

lgtm.

Probably I think the following change is also good.

--- ibus/ui/gtk3/keybindingmanager.vala.orig
+++ ibus/ui/gtk3/keybindingmanager.vala
@@ -85,8 +85,6 @@ public class KeybindingManager : GLib.Ob
         Gdk.ModifierType modifiers;
         Gtk.accelerator_parse(accelerator, out keysym, out modifiers);
 
-        get_primary_modifier(modifiers);
-
         unowned X.Display display = Gdk.x11_get_default_xdisplay();
 
         int keycode = display.keysym_to_keycode(keysym);
@@ -147,7 +145,7 @@ public class KeybindingManager : GLib.Ob
             Gdk.ModifierType.SHIFT_MASK,
             Gdk.ModifierType.LOCK_MASK
         };
-        foreach (var mask in masks) {
+        foreach (uint mask in masks) {
             if ((binding_mask & mask) == mask)
                 return mask;
         }

Expand All Messages | Collapse All Messages