Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2189)

Issue 575530107: Issue 5695: reduce dynamic casting (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by Dan Eble
Modified:
4 years, 3 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5695/ Here are a few miscellaneous things that I've been holding onto for a while because they would have been out of context in other reviews. Each file is in a separate commit, though they're squashed in this review. 1: defer dynamic_cast in Tie_column::add_tie 2: reduce unsmobbing in Spaceable_grob::get_spring 3: reduce unsmobbing in Paper_column::is_musical

Patch Set 1 #

Total comments: 1

Patch Set 2 : simplify Spaceable_grob::get_spring #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -18 lines) Patch
M lily/paper-column.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M lily/spaceable-grob.cc View 1 1 chunk +9 lines, -12 lines 0 comments Download
M lily/tie-column.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Dan Eble
4 years, 3 months ago (2020-01-25 16:57:43 UTC) #1
dak
https://codereview.appspot.com/575530107/diff/581530050/lily/spaceable-grob.cc File lily/spaceable-grob.cc (right): https://codereview.appspot.com/575530107/diff/581530050/lily/spaceable-grob.cc#newcode92 lily/spaceable-grob.cc:92: break; That looks still too complicated. Just do return ...
4 years, 3 months ago (2020-01-25 17:37:11 UTC) #2
Dan Eble
4 years, 3 months ago (2020-01-25 18:11:55 UTC) #3
simplify Spaceable_grob::get_spring
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b