Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(43)

Issue 5754058: Support for Runtime CPU type detection via builtins

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by Sriraman
Modified:
9 years, 4 months ago
Reviewers:
hjl.tools, gerald, richard.guenther, matz, ubizjak, davidxl
CC:
gcc-patches_gcc.gnu.org
Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Support for Runtime CPU type detection via builtins #

Patch Set 3 : Support for Runtime CPU type detection via builtins #

Patch Set 4 : Support for Runtime CPU type detection via builtins #

Patch Set 5 : Support for Runtime CPU type detection via builtins #

Unified diffs Side-by-side diffs Delta from patch set Stats (+898 lines, -1 line) Patch
gcc/config/i386/i386.c View 1 2 3 5 chunks +388 lines, -0 lines 0 comments Download
gcc/config/i386/i386-builtin-types.def View 1 2 1 chunk +1 line, -0 lines 0 comments Download
gcc/doc/extend.texi View 1 2 3 4 1 chunk +134 lines, -0 lines 0 comments Download
gcc/testsuite/gcc.target/i386/builtin_target.c View 1 2 3 1 chunk +65 lines, -0 lines 0 comments Download
libgcc/config.host View 1 2 1 chunk +1 line, -1 line 0 comments Download
libgcc/config/i386/i386-cpuinfo.c View 1 2 3 1 chunk +298 lines, -0 lines 0 comments Download
libgcc/config/i386/libgcc-glibc.ver View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
libgcc/config/i386/t-cpuinfo View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 36
richard.guenther_gmail.com
On Wed, Mar 7, 2012 at 1:49 AM, Sriraman Tallam <tmsriram@google.com> wrote: > Patch for ...
9 years, 7 months ago (2012-03-07 13:51:36 UTC) #1
davidxl
On Wed, Mar 7, 2012 at 5:51 AM, Richard Guenther <richard.guenther@gmail.com> wrote: > On Wed, ...
9 years, 7 months ago (2012-03-08 20:35:23 UTC) #2
richard.guenther_gmail.com
On Thu, Mar 8, 2012 at 9:35 PM, Xinliang David Li <davidxl@google.com> wrote: > On ...
9 years, 7 months ago (2012-03-12 11:16:39 UTC) #3
Sriraman
Subject:Support for Runtime CPU type detection via builtins Hi, I have uploaded a new patch ...
9 years, 7 months ago (2012-03-30 00:13:13 UTC) #4
matz_suse.de
Hi, On Thu, 29 Mar 2012, Sriraman Tallam wrote: > +struct __processor_model > +{ > ...
9 years, 7 months ago (2012-03-30 12:47:12 UTC) #5
Sriraman
On Fri, Mar 30, 2012 at 5:47 AM, Michael Matz <matz@suse.de> wrote: > Hi, > ...
9 years, 7 months ago (2012-03-30 23:03:00 UTC) #6
richard.guenther_gmail.com
On Sat, Mar 31, 2012 at 1:03 AM, Sriraman Tallam <tmsriram@google.com> wrote: > On Fri, ...
9 years, 6 months ago (2012-04-02 12:38:19 UTC) #7
Sriraman
On Mon, Apr 2, 2012 at 5:38 AM, Richard Guenther <richard.guenther@gmail.com> wrote: > On Sat, ...
9 years, 6 months ago (2012-04-02 17:59:55 UTC) #8
Sriraman
On Mon, Apr 2, 2012 at 5:38 AM, Richard Guenther <richard.guenther@gmail.com> wrote: > On Sat, ...
9 years, 6 months ago (2012-04-03 00:48:04 UTC) #9
Sriraman
Hi, i386 maintainers - Is this patch ok? Thanks, -Sri. On Mon, Apr 2, 2012 ...
9 years, 6 months ago (2012-04-03 19:47:39 UTC) #10
gerald_pfeifer.com
On Thu, 29 Mar 2012, Sriraman Tallam wrote: > Hi, > > I have made ...
9 years, 6 months ago (2012-04-08 13:18:02 UTC) #11
Sriraman
On Sun, Apr 8, 2012 at 6:17 AM, Gerald Pfeifer <gerald@pfeifer.com> wrote: > On Thu, ...
9 years, 6 months ago (2012-04-09 17:18:42 UTC) #12
Sriraman
Ping. On Tue, Apr 3, 2012 at 12:47 PM, Sriraman Tallam <tmsriram@google.com> wrote: > Hi, ...
9 years, 6 months ago (2012-04-12 23:14:52 UTC) #13
Sriraman
Ping. On Thu, Apr 12, 2012 at 4:14 PM, Sriraman Tallam <tmsriram@google.com> wrote: > Ping. ...
9 years, 6 months ago (2012-04-18 23:08:34 UTC) #14
ubizjak_gmail.com
On Tue, Apr 3, 2012 at 9:47 PM, Sriraman Tallam <tmsriram@google.com> wrote: > i386 maintainers ...
9 years, 6 months ago (2012-04-23 08:19:52 UTC) #15
Sriraman
Hi, On Mon, Apr 23, 2012 at 1:19 AM, Uros Bizjak <ubizjak@gmail.com> wrote: > On ...
9 years, 6 months ago (2012-04-23 16:59:25 UTC) #16
Sriraman
On Mon, Apr 23, 2012 at 1:19 AM, Uros Bizjak <ubizjak@gmail.com> wrote: > On Tue, ...
9 years, 6 months ago (2012-04-23 17:04:36 UTC) #17
ubizjak_gmail.com
On Mon, Apr 23, 2012 at 6:59 PM, Sriraman Tallam <tmsriram@google.com> wrote: >>> i386 maintainers ...
9 years, 6 months ago (2012-04-23 19:16:53 UTC) #18
ubizjak_gmail.com
On Mon, Apr 23, 2012 at 6:59 PM, Sriraman Tallam <tmsriram@google.com> wrote: > * config/i386/i386.c ...
9 years, 6 months ago (2012-04-23 19:30:54 UTC) #19
hjl.tools_gmail.com
On Mon, Apr 23, 2012 at 9:59 AM, Sriraman Tallam <tmsriram@google.com> wrote: > Hi, > ...
9 years, 6 months ago (2012-04-23 20:41:24 UTC) #20
Sriraman
On Mon, Apr 23, 2012 at 12:16 PM, Uros Bizjak <ubizjak@gmail.com> wrote: > On Mon, ...
9 years, 6 months ago (2012-04-23 20:43:21 UTC) #21
hjl.tools_gmail.com
On Mon, Apr 23, 2012 at 1:43 PM, Sriraman Tallam <tmsriram@google.com> wrote: > On Mon, ...
9 years, 6 months ago (2012-04-24 00:46:07 UTC) #22
Sriraman
Hi, Thanks for all the comments. I have made all the changes as mentioned and ...
9 years, 6 months ago (2012-04-25 00:10:04 UTC) #23
hjl.tools_gmail.com
On Tue, Apr 24, 2012 at 5:10 PM, Sriraman Tallam <tmsriram@google.com> wrote: > Hi, > ...
9 years, 6 months ago (2012-04-25 00:24:08 UTC) #24
Sriraman
On Tue, Apr 24, 2012 at 5:24 PM, H.J. Lu <hjl.tools@gmail.com> wrote: > On Tue, ...
9 years, 6 months ago (2012-04-25 02:06:45 UTC) #25
hjl.tools_gmail.com
On Tue, Apr 24, 2012 at 7:06 PM, Sriraman Tallam <tmsriram@google.com> wrote: > On Tue, ...
9 years, 6 months ago (2012-04-25 02:39:14 UTC) #26
Sriraman
On Tue, Apr 24, 2012 at 7:39 PM, H.J. Lu <hjl.tools@gmail.com> wrote: > On Tue, ...
9 years, 6 months ago (2012-04-25 21:25:08 UTC) #27
hjl.tools_gmail.com
On Wed, Apr 25, 2012 at 2:25 PM, Sriraman Tallam <tmsriram@google.com> wrote: > On Tue, ...
9 years, 6 months ago (2012-04-25 21:28:37 UTC) #28
Sriraman
On Wed, Apr 25, 2012 at 2:28 PM, H.J. Lu <hjl.tools@gmail.com> wrote: > On Wed, ...
9 years, 6 months ago (2012-04-25 21:45:15 UTC) #29
Sriraman
Hi H.J, Could you please review this patch for AVX2 check? * config/i386/i386-cpuinfo.c (FEATURE_AVX2): New ...
9 years, 6 months ago (2012-04-25 23:38:43 UTC) #30
hjl.tools_gmail.com
On Wed, Apr 25, 2012 at 4:38 PM, Sriraman Tallam <tmsriram@google.com> wrote: > Hi H.J, ...
9 years, 6 months ago (2012-04-25 23:52:14 UTC) #31
Sriraman
Patch committed. Thanks, -Sri. On Wed, Apr 25, 2012 at 4:52 PM, H.J. Lu <hjl.tools@gmail.com> ...
9 years, 6 months ago (2012-04-26 00:52:28 UTC) #32
Sriraman
Hi H.J., I am attaching a patch to add __cpu_indicator_init to the list of symbols ...
9 years, 4 months ago (2012-06-05 22:00:29 UTC) #33
hjl.tools_gmail.com
On Tue, Jun 5, 2012 at 3:00 PM, Sriraman Tallam <tmsriram@google.com> wrote: > Hi H.J., ...
9 years, 4 months ago (2012-06-06 13:52:01 UTC) #34
Sriraman
On Jun 6, 2012 6:52 AM, "H.J. Lu" <hjl.tools@gmail.com> wrote: > > On Tue, Jun ...
9 years, 4 months ago (2012-06-06 15:04:22 UTC) #35
Sriraman
9 years, 4 months ago (2012-06-12 02:56:32 UTC) #36
On Wed, Jun 6, 2012 at 6:52 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Tue, Jun 5, 2012 at 3:00 PM, Sriraman Tallam <tmsriram@google.com> wrote:
>> Hi H.J.,
>>
>> I am attaching a patch to add __cpu_indicator_init to the list of
>> symbols to be versioned and exported in libgcc_s.so. Also, updating
>> builtin_target.c test to explicitly do a CPUID and check if the
>> features are identified correctly like you had suggested earlier.
>>
>> Patch ok?
>>
>>
>>        * config/i386/libgcc-bsd.ver: Version symbol __cpu_indicator_init.
>>        * config/i386/libgcc-sol2.ver: Ditto.
>>        * config/i386/libgcc-glibc.ver: Ditto.
>>
>>
>>        * gcc.target/i386/builtin_target.c (vendor_signatures): New enum.
>>        (check_intel_cpu_model): New function.
>>        (check_amd_cpu_model): New function.
>>        (check_features): New function.
>>        (__get_cpuid_output): New function.
>>        (check_detailed): New function.
>>        (fn1): Rename to quick_check.
>>        (main): Update to call quick_check and call check_detailed.
>>
>
> It looks good.

I submitted this patch. I am working on fixing the problem mentioned
below about cpu indicator symbols from libgcc_s.so being used in C
programs.

Thanks,
-Sri.


The only problem is for C programs,  __cpu_model and
> __cpu_indicator_init in libgcc_s.so aren't used at all.  I suggested
> in
>
> http://gcc.gnu.org/ml/gcc-patches/2012-05/msg01816.html
>
> We can do one
> of 3 things:
>
> 1. Abuse libgcc_eh.a by moving __cpu_model and __cpu_indicator_init
> from libgcc.a to libgcc_eh.a.
> 2. Rename libgcc_eh.a to libgcc_static.a and move __cpu_model and
> __cpu_indicator_init from libgcc.a to libgcc_static.a.
> 3. Add  libgcc_static.a and move __cpu_model and __cpu_indicator_ini
>  from libgcc.a to libgcc_static.a.  We treat libgcc_static.a similar to
> libgcc_eh.a.
>
>
> --
> H.J.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b