Issue 5753058: Refine coding style.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5753058: Refine coding style. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by Peng

Modified:
12 years, 8 months ago

Reviewers:
adam2, fujiwara

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Refine coding style. BUG=None TEST=Manually

Patch Set 1 #

Total comments: 3

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	ui/gtk3/handle.vala	View		2 chunks	+4 lines, -2 lines	3 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adam2

12 years, 8 months ago (2012-03-07 02:11:59 UTC) #3

http://codereview.appspot.com/5753058/diff/1/ui/gtk3/handle.vala
File ui/gtk3/handle.vala (right):

http://codereview.appspot.com/5753058/diff/1/ui/gtk3/handle.vala#newcode109
ui/gtk3/handle.vala:109: } while (false);
sdasdasdasd

http://codereview.appspot.com/5753058/diff/1/ui/gtk3/handle.vala#newcode115
ui/gtk3/handle.vala:115: m_press_pos.y = (int)event.y_root - y;
qwdqwdqw

http://codereview.appspot.com/5753058/diff/1/ui/gtk3/handle.vala#newcode133
ui/gtk3/handle.vala:133: return false;
dsfdfdfsdfsdfsdffsd

Expand All Messages | Collapse All Messages