Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(254)

Issue 5752067: code review 5752067: exp/wingui: getting relocated to (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by brainman
Modified:
13 years, 1 month ago
Reviewers:
CC:
golang-dev, minux1, r
Visibility:
Public.

Description

exp/wingui: getting relocated to go get code.google.com/p/gowingui

Patch Set 1 #

Patch Set 2 : diff -r e161795e4095 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e161795e4095 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 2b1a6605a310 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 5 : diff -r 8b6c1bf3cd89 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -490 lines) Patch
M doc/go1.html View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M doc/go1.tmpl View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
R src/pkg/exp/wingui/Makefile View 1 1 chunk +0 lines, -9 lines 0 comments Download
R src/pkg/exp/wingui/gui.go View 1 1 chunk +0 lines, -155 lines 0 comments Download
R src/pkg/exp/wingui/winapi.go View 1 1 chunk +0 lines, -134 lines 0 comments Download
R src/pkg/exp/wingui/zwinapi.go View 1 1 chunk +0 lines, -192 lines 0 comments Download

Messages

Total messages: 8
brainman
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 1 month ago (2012-03-07 05:00:09 UTC) #1
minux1
I think this has a side effect of advertising people to use mksyscall_windows.pl in their ...
13 years, 1 month ago (2012-03-07 05:06:27 UTC) #2
brainman
On 2012/03/07 05:06:27, minux wrote: > I think this has a side effect of advertising ...
13 years, 1 month ago (2012-03-07 05:16:41 UTC) #3
r
Please add a few words to go1.{tmpl,html}
13 years, 1 month ago (2012-03-07 05:39:38 UTC) #4
brainman
Hello golang-dev@googlegroups.com, minux.ma@gmail.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 1 month ago (2012-03-07 06:42:23 UTC) #5
r
LGTM
13 years, 1 month ago (2012-03-07 06:45:53 UTC) #6
r
LGTM http://codereview.appspot.com/5752067/diff/5002/doc/go1.tmpl File doc/go1.tmpl (right): http://codereview.appspot.com/5752067/diff/5002/doc/go1.tmpl#newcode661 doc/go1.tmpl:661: Go 1 has moved a number of packages ...
13 years, 1 month ago (2012-03-07 06:47:22 UTC) #7
brainman
13 years, 1 month ago (2012-03-07 06:48:18 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=abf39116ffac ***

exp/wingui: getting relocated to

go get code.google.com/p/gowingui

R=golang-dev, minux.ma, r
CC=golang-dev
http://codereview.appspot.com/5752067
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b