Issue 5752055: Upstream changes from Android repository.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5752055: Upstream changes from Android repository. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by DerekS

Modified:
12 years, 3 months ago

Reviewers:
caryclark1, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Upstream changes from Android repository. Committed: https://code.google.com/p/skia/source/detail?r=3449

Patch Set 2 : #

Total comments: 1

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+254 lines, -47 lines)			Patch
M	include/core/SkPath.h	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	include/core/SkThread_platform.h	View	1	1 chunk	+0 lines, -27 lines	0 comments	Download
M	include/utils/SkCamera.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/core/SkPath.cpp	View	1	4 chunks	+12 lines, -2 lines	0 comments	Download
M	src/effects/SkBlurMaskFilter.cpp	View	1	1 chunk	+1 line, -1 line	1 comment	Download
M	src/ports/FontHostConfiguration_android.h	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
M	src/ports/FontHostConfiguration_android.cpp	View	1	5 chunks	+81 lines, -9 lines	0 comments	Download
M	src/ports/SkFontHost_android.cpp	View	1	10 chunks	+124 lines, -8 lines	0 comments	Download
M	src/utils/SkCamera.cpp	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	tests/CanvasTest.cpp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

caryclark1

http://codereview.appspot.com/5752055/diff/1/include/core/SkPath.h File include/core/SkPath.h (right): http://codereview.appspot.com/5752055/diff/1/include/core/SkPath.h#newcode736 include/core/SkPath.h:736: void setSourcePath(const SkPath* path); I guess this is for ...

12 years, 4 months ago (2012-03-06 14:47:28 UTC) #3

reed1

12 years, 3 months ago (2012-03-20 20:43:37 UTC) #4

http://codereview.appspot.com/5752055/diff/5001/src/effects/SkBlurMaskFilter.cpp
File src/effects/SkBlurMaskFilter.cpp (left):

http://codereview.appspot.com/5752055/diff/5001/src/effects/SkBlurMaskFilter....
src/effects/SkBlurMaskFilter.cpp:25: virtual void computeFastBounds(const
SkRect& src, SkRect* dest) SK_OVERRIDE;
you may land this file now :)

Expand All Messages | Collapse All Messages