Issue 5752053: Apply SimpTradConverter to candidates and fix bugs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5752053: Apply SimpTradConverter to candidates and fix bugs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by hsumita

Modified:
12 years, 1 month ago

Reviewers:
shawn.p.huang, penghuang, Peng

CC:
komatsu, mukai, yusukes, nona, horo

Base URL:
git@github.com:pyzy/pyzy.git@master

Visibility:
Public.

More Reviews

Description

Apply SimpTradConverter to candidates and fix bugs BUG=Candidates text are always simplified chinese characters. TEST=Manually tested with client code.

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	src/PyZyPhoneticContext.cc	View		1 chunk	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

On 2012/03/06 09:09:14, hsumita wrote: lgtm. Does this issue exist in upstream ibus-pinyin? If yes, ...

12 years, 1 month ago (2012-03-06 14:47:27 UTC) #2

hsumita

12 years, 1 month ago (2012-03-06 17:21:06 UTC) #3

Thank you for your review!

I think there is no problem in ibus-pinyin.
At least ibus-pinyin of my PC (ver 1.3.11) doesn't have this issue.

Expand All Messages | Collapse All Messages