Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Delta Between Two Patch Sets: lily/spacing-engraver.cc

Issue 573670043: Refactor get/set_property to take the item as first argument
Left Patch Set: script generated commit (after preparation) Created 4 years, 11 months ago
Right Patch Set: Manual completion of patch set Created 4 years, 11 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lily/spacing-determine-loose-columns.cc ('k') | lily/spacing-interface.cc » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 This file is part of LilyPond, the GNU music typesetter. 2 This file is part of LilyPond, the GNU music typesetter.
3 3
4 Copyright (C) 1999--2020 Han-Wen Nienhuys <hanwen@xs4all.nl> 4 Copyright (C) 1999--2020 Han-Wen Nienhuys <hanwen@xs4all.nl>
5 5
6 LilyPond is free software: you can redistribute it and/or modify 6 LilyPond is free software: you can redistribute it and/or modify
7 it under the terms of the GNU General Public License as published by 7 it under the terms of the GNU General Public License as published by
8 the Free Software Foundation, either version 3 of the License, or 8 the Free Software Foundation, either version 3 of the License, or
9 (at your option) any later version. 9 (at your option) any later version.
10 10
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 void 195 void
196 Spacing_engraver::stop_translation_timestep () 196 Spacing_engraver::stop_translation_timestep ()
197 { 197 {
198 Paper_column *musical_column 198 Paper_column *musical_column
199 = unsmob<Paper_column> (get_property (this, "currentMusicalColumn")); 199 = unsmob<Paper_column> (get_property (this, "currentMusicalColumn"));
200 200
201 if (!spacing_) 201 if (!spacing_)
202 start_spanner (); 202 start_spanner ();
203 203
204 set_object (musical_column, "spacing", spacing_->self_scm ()); 204 set_object (musical_column, "spacing", spacing_->self_scm ());
205 unsmob<Grob> (get_property (this, "currentCommandColumn")) 205 set_object (unsmob<Grob> (get_property (this, "currentCommandColumn")),
206 ->set_object (this, "spacing", spacing_->self_scm ()); 206 "spacing", spacing_->self_scm ());
207 207
208 SCM proportional = get_property (this, "proportionalNotationDuration"); 208 SCM proportional = get_property (this, "proportionalNotationDuration");
209 if (unsmob<Moment> (proportional)) 209 if (unsmob<Moment> (proportional))
210 { 210 {
211 set_property (musical_column, "shortest-playing-duration", proportional); 211 set_property (musical_column, "shortest-playing-duration", proportional);
212 set_property (musical_column, "shortest-starter-duration", proportional); 212 set_property (musical_column, "shortest-starter-duration", proportional);
213 set_property (musical_column, "used", SCM_BOOL_T); 213 set_property (musical_column, "used", SCM_BOOL_T);
214 return; 214 return;
215 } 215 }
216 216
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 "SpacingSpanner ", 282 "SpacingSpanner ",
283 283
284 /* read */ 284 /* read */
285 "currentMusicalColumn " 285 "currentMusicalColumn "
286 "currentCommandColumn " 286 "currentCommandColumn "
287 "proportionalNotationDuration ", 287 "proportionalNotationDuration ",
288 288
289 /* write */ 289 /* write */
290 "" 290 ""
291 ); 291 );
LEFTRIGHT

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b