Refactor get/set_property to take the item as first argument

lily/script-engraver.cc

 /*
   This file is part of LilyPond, the GNU music typesetter.
 
   Copyright (C) 1997--2020 Han-Wen Nienhuys <hanwen@xs4all.nl>
 
   LilyPond is free software: you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
   the Free Software Foundation, either version 3 of the License, or
   (at your option) any later version.
 
@@ skipping 61 matching lines @@
 Script_engraver::Script_engraver (Context *c)
   : Engraver (c)
 {
 }
 
 void
 Script_engraver::listen_articulation (Stream_event *ev)
 {
   /* Discard double articulations for part-combining.  */
   for (vsize i = 0; i < scripts_.size (); i++)
-    if (ly_is_equal (scripts_[i].event_
-                     ->get_property ("articulation-type"),
-                     ev->get_property ("articulation-type")))
+    if (ly_is_equal (get_property (scripts_[i].event_
+                     , "articulation-type"),
+                     get_property (ev, "articulation-type")))
       return;
 
   Script_tuple t;
   t.event_ = ev;
   scripts_.push_back (t);
 }
 
 void
 copy_property (Grob *g, SCM sym, SCM alist)
 {
-  if (scm_is_null (g->get_property (sym)))
+  if (scm_is_null (get_property (g, sym)))
     {
       SCM entry = scm_assoc (sym, alist);
       if (scm_is_pair (entry))
-        g->set_property (sym, scm_cdr (entry));
+        set_property (g, sym, scm_cdr (entry));
     }
 }
 
 /* Add the properties, one by one for each Script.  A little memory
    could be saved by tacking the props onto the Script grob (i.e. make
    ScriptStaccato , ScriptMarcato, etc. ).
 */
 void
 make_script_from_event (Grob *p, Context *tg, SCM art_type, size_t index)
 {
-  SCM alist = tg->get_property ("scriptDefinitions");
+  SCM alist = get_property (tg, "scriptDefinitions");
   SCM art = scm_assoc (art_type, alist);
 
   if (scm_is_false (art))
     {
       /* FIXME: */
       warning (_ ("do not know how to interpret articulation:"));
       warning (_ (" scheme encoding: "));
       scm_write (art_type, scm_current_error_port ());
       message ("");
       return;
@@ skipping 14 matching lines @@
 
       if (scm_is_eq (sym, ly_symbol2scm ("script-priority")))
         {
           priority_found = true;
           /* Make sure they're in order of user input by adding index i.
              Don't use the direction in this priority. Smaller means closer
              to the head.  */
           val = scm_sum (val, scm_from_size_t (index));
         }
 
-      SCM preset = p->get_property_data (sym);
+      SCM preset = get_property_data (p, sym);
       if (scm_is_null (val)
           || scm_is_false (scm_call_1 (type, preset)))
-        p->set_property (sym, val);
+        set_property (p, sym, val);
     }
 
   if (!priority_found)
     {
-      p->set_property ("script-priority", scm_from_size_t (index));
+      set_property (p, "script-priority", scm_from_size_t (index));
     }
 }
 
 void
 Script_engraver::process_music ()
 {
   for (vsize i = 0; i < scripts_.size (); i++)
     {
       Stream_event *ev = scripts_[i].event_;
 
       Grob *p = make_item ("Script", ev->self_scm ());
 
       make_script_from_event (p, context (),
-                              ev->get_property ("articulation-type"),
+                              get_property (ev, "articulation-type"),
                               i);
 
       scripts_[i].script_ = p;
 
-      SCM force_dir = ev->get_property ("direction");
+      SCM force_dir = get_property (ev, "direction");
       if (is_direction (force_dir) && to_dir (force_dir))
-        p->set_property ("direction", force_dir);
+        set_property (p, "direction", force_dir);
     }
 }
 
 void
 Script_engraver::acknowledge_stem (Grob_info info)
 {
   for (vsize i = 0; i < scripts_.size (); i++)
     {
       Grob *e = scripts_[i].script_;
 
-      if (to_dir (e->get_property ("side-relative-direction")))
-        e->set_object ("direction-source", info.grob ()->self_scm ());
+      if (to_dir (get_property (e, "side-relative-direction")))
+        set_object (e, "direction-source", info.grob ()->self_scm ());
 
       Side_position_interface::add_support (e, info.grob ());
     }
 }
 
 void
 Script_engraver::acknowledge_stem_tremolo (Grob_info info)
 {
   for (vsize i = 0; i < scripts_.size (); i++)
     {
@@ skipping 95 matching lines @@
 
                 /* create */
                 "Script ",
 
                 /* read */
                 "scriptDefinitions ",
 
                 /* write */
                 ""
                );