Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Delta Between Two Patch Sets: lily/ledger-line-engraver.cc

Issue 573670043: Refactor get/set_property to take the item as first argument
Left Patch Set: Created 4 years, 11 months ago
Right Patch Set: Manual completion of patch set Created 4 years, 11 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
Right: Side by side diff | Download
« no previous file with change/comment | « lily/laissez-vibrer-engraver.cc ('k') | lily/ledger-line-spanner.cc » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
(no file at all)
1 /* 1 /*
2 This file is part of LilyPond, the GNU music typesetter. 2 This file is part of LilyPond, the GNU music typesetter.
3 3
4 Copyright (C) 2004--2020 Han-Wen Nienhuys <hanwen@xs4all.nl> 4 Copyright (C) 2004--2020 Han-Wen Nienhuys <hanwen@xs4all.nl>
5 5
6 LilyPond is free software: you can redistribute it and/or modify 6 LilyPond is free software: you can redistribute it and/or modify
7 it under the terms of the GNU General Public License as published by 7 it under the terms of the GNU General Public License as published by
8 the Free Software Foundation, either version 3 of the License, or 8 the Free Software Foundation, either version 3 of the License, or
9 (at your option) any later version. 9 (at your option) any later version.
10 10
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 { 51 {
52 span_ = 0; 52 span_ = 0;
53 } 53 }
54 54
55 void 55 void
56 Ledger_line_engraver::start_spanner () 56 Ledger_line_engraver::start_spanner ()
57 { 57 {
58 assert (!span_); 58 assert (!span_);
59 59
60 span_ = make_spanner ("LedgerLineSpanner", SCM_EOL); 60 span_ = make_spanner ("LedgerLineSpanner", SCM_EOL);
61 span_->set_bound (LEFT, unsmob<Grob> (get_property ("currentCommandColumn"))); 61 span_->set_bound (LEFT, unsmob<Grob> (get_property (this, "currentCommandColum n")));
62 } 62 }
63 63
64 void 64 void
65 Ledger_line_engraver::stop_translation_timestep () 65 Ledger_line_engraver::stop_translation_timestep ()
66 { 66 {
67 if (span_) 67 if (span_)
68 { 68 {
69 for (vsize i = 0; i < ledgered_grobs_.size (); i++) 69 for (vsize i = 0; i < ledgered_grobs_.size (); i++)
70 { 70 {
71 if (!to_boolean (ledgered_grobs_[i]->get_property ("no-ledgers"))) 71 if (!to_boolean (get_property (ledgered_grobs_[i], "no-ledgers")))
72 Pointer_group_interface::add_grob (span_, 72 Pointer_group_interface::add_grob (span_,
73 ly_symbol2scm ("note-heads"), 73 ly_symbol2scm ("note-heads"),
74 ledgered_grobs_[i]); 74 ledgered_grobs_[i]);
75 } 75 }
76 } 76 }
77 77
78 ledgered_grobs_.clear (); 78 ledgered_grobs_.clear ();
79 } 79 }
80 80
81 void 81 void
(...skipping 10 matching lines...) Expand all
92 Ledger_line_engraver::finalize () 92 Ledger_line_engraver::finalize ()
93 { 93 {
94 stop_spanner (); 94 stop_spanner ();
95 } 95 }
96 96
97 void 97 void
98 Ledger_line_engraver::stop_spanner () 98 Ledger_line_engraver::stop_spanner ()
99 { 99 {
100 if (span_) 100 if (span_)
101 { 101 {
102 span_->set_bound (RIGHT, unsmob<Grob> (get_property ("currentCommandColumn "))); 102 span_->set_bound (RIGHT, unsmob<Grob> (get_property (this, "currentCommand Column")));
103 span_ = 0; 103 span_ = 0;
104 } 104 }
105 } 105 }
106 106
107 void 107 void
108 Ledger_line_engraver::acknowledge_staff_symbol (Grob_info s) 108 Ledger_line_engraver::acknowledge_staff_symbol (Grob_info s)
109 { 109 {
110 Spanner *sym = dynamic_cast<Spanner *> (s.grob ()); 110 Spanner *sym = dynamic_cast<Spanner *> (s.grob ());
111 111
112 if (!span_ 112 if (!span_
(...skipping 24 matching lines...) Expand all
137 137
138 /* create */ 138 /* create */
139 "LedgerLineSpanner ", 139 "LedgerLineSpanner ",
140 140
141 /* read */ 141 /* read */
142 "", 142 "",
143 143
144 /* write */ 144 /* write */
145 "" 145 ""
146 ); 146 );
LEFTRIGHT

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b