Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(44)

Delta Between Two Patch Sets: lily/episema-engraver.cc

Issue 573670043: Refactor get/set_property to take the item as first argument
Left Patch Set: Created 4 years, 11 months ago
Right Patch Set: Manual completion of patch set Created 4 years, 11 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
Right: Side by side diff | Download
« no previous file with change/comment | « lily/engraver-group.cc ('k') | lily/event-chord-iterator.cc » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
(no file at all)
1 /* 1 /*
2 This file is part of LilyPond, the GNU music typesetter. 2 This file is part of LilyPond, the GNU music typesetter.
3 3
4 Copyright (C) 2010--2020 Neil Puttock <n.puttock@gmail.com> 4 Copyright (C) 2010--2020 Neil Puttock <n.puttock@gmail.com>
5 5
6 LilyPond is free software: you can redistribute it and/or modify 6 LilyPond is free software: you can redistribute it and/or modify
7 it under the terms of the GNU General Public License as published by 7 it under the terms of the GNU General Public License as published by
8 the Free Software Foundation, either version 3 of the License, or 8 the Free Software Foundation, either version 3 of the License, or
9 (at your option) any later version. 9 (at your option) any later version.
10 10
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 { 55 {
56 finished_ = 0; 56 finished_ = 0;
57 current_event_ = 0; 57 current_event_ = 0;
58 span_ = 0; 58 span_ = 0;
59 event_drul_.set (0, 0); 59 event_drul_.set (0, 0);
60 } 60 }
61 61
62 void 62 void
63 Episema_engraver::listen_episema (Stream_event *ev) 63 Episema_engraver::listen_episema (Stream_event *ev)
64 { 64 {
65 Direction d = to_dir (ev->get_property ("span-direction")); 65 Direction d = to_dir (get_property (ev, "span-direction"));
66 // Must not ASSIGN_EVENT_ONCE here, since episema 66 // Must not ASSIGN_EVENT_ONCE here, since episema
67 // can be typeset over a single neume 67 // can be typeset over a single neume
68 event_drul_[d] = ev; 68 event_drul_[d] = ev;
69 } 69 }
70 70
71 void 71 void
72 Episema_engraver::process_music () 72 Episema_engraver::process_music ()
73 { 73 {
74 if (event_drul_[START]) 74 if (event_drul_[START])
75 { 75 {
(...skipping 25 matching lines...) Expand all
101 101
102 void 102 void
103 Episema_engraver::typeset_all () 103 Episema_engraver::typeset_all ()
104 { 104 {
105 if (finished_) 105 if (finished_)
106 { 106 {
107 if (!finished_->get_bound (RIGHT)) 107 if (!finished_->get_bound (RIGHT))
108 { 108 {
109 Grob *col = (note_columns_.size () 109 Grob *col = (note_columns_.size ()
110 ? note_columns_.back () 110 ? note_columns_.back ()
111 : unsmob<Grob> (get_property ("currentMusicalColumn"))); 111 : unsmob<Grob> (get_property (this, "currentMusicalColumn ")));
112 finished_->set_bound (RIGHT, col); 112 finished_->set_bound (RIGHT, col);
113 } 113 }
114 finished_ = 0; 114 finished_ = 0;
115 } 115 }
116 } 116 }
117 117
118 void 118 void
119 Episema_engraver::stop_translation_timestep () 119 Episema_engraver::stop_translation_timestep ()
120 { 120 {
121 if (span_ && !span_->get_bound (LEFT)) 121 if (span_ && !span_->get_bound (LEFT))
122 { 122 {
123 Grob *col = (note_columns_.size () 123 Grob *col = (note_columns_.size ()
124 ? note_columns_.front () 124 ? note_columns_.front ()
125 : unsmob<Grob> (get_property ("currentMusicalColumn"))); 125 : unsmob<Grob> (get_property (this, "currentMusicalColumn"))) ;
126 span_->set_bound (LEFT, col); 126 span_->set_bound (LEFT, col);
127 } 127 }
128 128
129 typeset_all (); 129 typeset_all ();
130 event_drul_.set (0, 0); 130 event_drul_.set (0, 0);
131 } 131 }
132 132
133 void 133 void
134 Episema_engraver::finalize () 134 Episema_engraver::finalize ()
135 { 135 {
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 177
178 /* create */ 178 /* create */
179 "Episema ", 179 "Episema ",
180 180
181 /* read */ 181 /* read */
182 "", 182 "",
183 183
184 /* write */ 184 /* write */
185 "" 185 ""
186 ); 186 );
LEFTRIGHT

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b