Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 573340043: Run 2to3 --write --nobackups . (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 1 week ago by hahnjo
Modified:
3 months, 3 weeks ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Run 2to3 --write --nobackups .

Patch Set 1 #

Patch Set 2 : Re-run #

Patch Set 3 : Remove coverage.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+445 lines, -439 lines) Patch
M python/auxiliar/buildlib.py View 1 chunk +1 line, -1 line 0 comments Download
M python/auxiliar/postprocess_html.py View 3 chunks +4 lines, -3 lines 0 comments Download
M python/book_base.py View 1 chunk +2 lines, -2 lines 0 comments Download
M python/book_snippets.py View 1 8 chunks +15 lines, -16 lines 0 comments Download
M python/convertrules.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M python/fontextract.py View 4 chunks +6 lines, -6 lines 0 comments Download
M python/langdefs.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M python/lilylib.py View 1 7 chunks +15 lines, -14 lines 0 comments Download
M python/midi.py View 1 4 chunks +4 lines, -4 lines 0 comments Download
M python/musicexp.py View 1 6 chunks +16 lines, -18 lines 0 comments Download
M python/musicxml.py View 1 24 chunks +40 lines, -40 lines 0 comments Download
M python/rational.py View 12 chunks +15 lines, -15 lines 0 comments Download
M python/safeeval.py View 2 chunks +5 lines, -5 lines 0 comments Download
M python/utilities.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
M scripts/abc2ly.py View 18 chunks +19 lines, -19 lines 0 comments Download
M scripts/auxiliar/check_texi_refs.py View 8 chunks +12 lines, -9 lines 0 comments Download
M scripts/auxiliar/check_translation.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/auxiliar/find-superfluous-includes.py View 1 chunk +4 lines, -4 lines 0 comments Download
M scripts/auxiliar/fixcc.py View 1 5 chunks +8 lines, -8 lines 0 comments Download
M scripts/auxiliar/makelsr.py View 2 chunks +5 lines, -5 lines 0 comments Download
M scripts/auxiliar/musicxml_generate_intervals.py View 3 chunks +7 lines, -7 lines 0 comments Download
M scripts/auxiliar/musicxml_generate_keys.py View 5 chunks +6 lines, -6 lines 0 comments Download
M scripts/auxiliar/musicxml_generate_timesignatures.py View 5 chunks +6 lines, -6 lines 0 comments Download
M scripts/auxiliar/node-menuify.py View 2 chunks +3 lines, -3 lines 0 comments Download
M scripts/auxiliar/prepare-web-media.py View 3 chunks +6 lines, -6 lines 0 comments Download
M scripts/auxiliar/readlink.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/auxiliar/ref_check.py View 7 chunks +11 lines, -11 lines 0 comments Download
M scripts/auxiliar/show_skyline_command.py View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/auxiliar/skyline_viewer.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/auxiliar/split-texidocs.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/auxiliar/tely-gettext.py View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/auxiliar/texi-langutils.py View 3 chunks +5 lines, -4 lines 0 comments Download
M scripts/auxiliar/translations-status.py View 5 chunks +7 lines, -5 lines 0 comments Download
M scripts/auxiliar/update-snippets.py View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/build/bib2texi.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/build/create-version-itexi.py View 2 chunks +14 lines, -15 lines 0 comments Download
M scripts/build/create-weblinks-itexi.py View 3 chunks +22 lines, -23 lines 0 comments Download
M scripts/build/extract_texi_filenames.py View 1 5 chunks +8 lines, -8 lines 0 comments Download
M scripts/build/gen-emmentaler-scripts.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/build/genicon.py View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/build/grand-replace.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/build/install.py View 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/build/mass-link.py View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/build/mf-to-table.py View 1 3 chunks +5 lines, -5 lines 0 comments Download
M scripts/build/output-distance.py View 1 27 chunks +37 lines, -36 lines 0 comments Download
M scripts/build/relative.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/build/texi2omf.py View 1 4 chunks +4 lines, -4 lines 0 comments Download
M scripts/build/text2html.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/build/website_post.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/build/www_post.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/convert-ly.py View 1 3 chunks +5 lines, -5 lines 0 comments Download
M scripts/etf2ly.py View 1 9 chunks +15 lines, -15 lines 0 comments Download
M scripts/lilymidi.py View 1 1 chunk +13 lines, -13 lines 0 comments Download
M scripts/lilypond-book.py View 1 5 chunks +6 lines, -6 lines 0 comments Download
M scripts/lilysong.py View 1 4 chunks +6 lines, -6 lines 0 comments Download
M scripts/midi2ly.py View 1 10 chunks +15 lines, -15 lines 0 comments Download
M scripts/musicxml2ly.py View 1 26 chunks +39 lines, -38 lines 0 comments Download

Messages

Total messages: 3
hahnjo
Re-run
4 months, 1 week ago (2020-01-22 09:30:46 UTC) #1
hahnjo
Remove coverage.py
4 months ago (2020-01-25 12:28:05 UTC) #2
hahnjo
4 months ago (2020-01-27 12:55:59 UTC) #3
For future lookup, here's the last few lines of 2to3:
RefactoringTool: Warnings/messages while refactoring:
RefactoringTool: ### In file ./python/book_snippets.py ###
RefactoringTool: Line 716: You should use a for loop here
RefactoringTool: Line 707: You should use a for loop here
RefactoringTool: Line 738: You should use a for loop here
RefactoringTool: Line 739: You should use a for loop here
RefactoringTool: ### In file ./scripts/auxiliar/fixcc.py ###
RefactoringTool: Line 244: You should use a for loop here
RefactoringTool: ### In file ./scripts/auxiliar/makelsr.py ###
RefactoringTool: Line 304: You should use a for loop here
RefactoringTool: Line 307: You should use a for loop here
RefactoringTool: ### In file ./scripts/build/mass-link.py ###
RefactoringTool: Line 91: You should use a for loop here

Not something that needs urgent fixing, but maybe a good cleanup.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b