Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(83)

Issue 5732058: code review 5732058: weekly.2012-03-04 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by adg
Modified:
9 years, 7 months ago
Reviewers:
rsc
CC:
golang-dev, dsymonds, bradfitz, minux1
Visibility:
Public.

Description

weekly.2012-03-04

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r 9f5294988ba7 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -1 line) Patch
M .hgtags View 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/weekly.html View 1 chunk +118 lines, -0 lines 0 comments Download

Messages

Total messages: 8
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 7 months ago (2012-03-05 00:35:06 UTC) #1
dsymonds
LGTM http://codereview.appspot.com/5732058/diff/1/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5732058/diff/1/doc/devel/weekly.html#newcode117 doc/devel/weekly.html:117: run init on main thread, there were some ...
9 years, 7 months ago (2012-03-05 00:43:16 UTC) #2
bradfitz
Was hoping to have go get mydomain.com in this weekly. Oh well. Ping. On Mar ...
9 years, 7 months ago (2012-03-05 02:27:51 UTC) #3
minux1
I think we should wait for CL 5731059 as well.
9 years, 7 months ago (2012-03-05 02:29:58 UTC) #4
adg
On 5 March 2012 13:27, Brad Fitzpatrick <bradfitz@golang.org> wrote: > Was hoping to have go ...
9 years, 7 months ago (2012-03-05 03:07:32 UTC) #5
minux1
On Mon, Mar 5, 2012 at 11:07 AM, Andrew Gerrand <adg@golang.org> wrote: > On 5 ...
9 years, 7 months ago (2012-03-05 03:17:03 UTC) #6
adg
*** Submitted as http://code.google.com/p/go/source/detail?r=f4470a54e6db *** weekly.2012-03-04 R=golang-dev, dsymonds, bradfitz, minux.ma CC=golang-dev http://codereview.appspot.com/5732058 http://codereview.appspot.com/5732058/diff/1/doc/devel/weekly.html File doc/devel/weekly.html ...
9 years, 7 months ago (2012-03-05 04:45:55 UTC) #7
rsc
9 years, 7 months ago (2012-03-05 14:29:17 UTC) #8
On Sun, Mar 4, 2012 at 21:27, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Was hoping to have go get mydomain.com in this weekly. Oh well.

Sorry.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b