Check to see if font is TrueType before making TrueType specific calls.

Check to see if font is TrueType before making TrueType specific calls.
See chromium bug 116185
Committed: https://code.google.com/p/skia/source/detail?r=3309

[reed1, 2012-03-02 20:35:50]

lgtm

[Steve VanDeBogart, 2012-03-02 20:40:09]

https://codereview.appspot.com/5731046/diff/1/src/ports/SkFontHost_mac_corete...
File src/ports/SkFontHost_mac_coretext.cpp (right):

https://codereview.appspot.com/5731046/diff/1/src/ports/SkFontHost_mac_corete...
src/ports/SkFontHost_mac_coretext.cpp:1641: if (!GetTableSize(fontID, 'glyf')) {
Arthur (who ported the sfntly code to C++) says that non-ttf fonts could have a
glyf table, but only ttf should have a loca table.

If you want to consult a font expert, he suggests stuartg, who used to work on
Acrobat.

[reed1, 2012-03-02 20:44:03]

Steve, as the code in question is in your domain, feel free to change
the table we check for to whatever you think is best.

On Fri, Mar 2, 2012 at 3:40 PM,  <vandebo@chromium.org> wrote:
>
>
https://codereview.appspot.com/5731046/diff/1/src/ports/SkFontHost_mac_corete...
> File src/ports/SkFontHost_mac_coretext.cpp (right):
>
>
https://codereview.appspot.com/5731046/diff/1/src/ports/SkFontHost_mac_corete...
> src/ports/SkFontHost_mac_coretext.cpp:1641: if (!GetTableSize(fontID,
> 'glyf')) {
> Arthur (who ported the sfntly code to C++) says that non-ttf fonts could
> have a glyf table, but only ttf should have a loca table.
>
> If you want to consult a font expert, he suggests stuartg, who used to
> work on Acrobat.
>
> https://codereview.appspot.com/5731046/