Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 5731043: code review 5731043: ld: allow more -L options (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by minux1
Modified:
13 years ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

ld: allow more -L options Dynamically allocate the libdir array, so we won't need to bother it again. Enhances CL 5727043.

Patch Set 1 #

Patch Set 2 : diff -r 30fa4e16a80a https://code.google.com/p/go/ #

Total comments: 2

Patch Set 3 : diff -r d8586c9e6c89 https://code.google.com/p/go/ #

Patch Set 4 : diff -r d8586c9e6c89 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M src/cmd/ld/lib.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/ld/lib.c View 1 2 3 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 3
rsc1
LGTM http://codereview.appspot.com/5731043/diff/2001/src/cmd/ld/lib.c File src/cmd/ld/lib.c (right): http://codereview.appspot.com/5731043/diff/2001/src/cmd/ld/lib.c#newcode55 src/cmd/ld/lib.c:55: char **p; please put a blank line after ...
13 years ago (2012-03-02 20:06:31 UTC) #1
minux1
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
13 years ago (2012-03-02 20:13:10 UTC) #2
minux1
13 years ago (2012-03-02 20:14:40 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=ada18e5ef51f ***

ld: allow more -L options
        Dynamically allocate the libdir array, so we won't need to bother it
again.
        Enhances CL 5727043.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5731043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b