Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2431)

Issue 5730046: Enhance make dist (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by fujiwara
Modified:
12 years ago
Reviewers:
shawn.p.huang
Base URL:
git://github.com/ibus/ibus.git@master
Visibility:
Public.

Description

Enhance make dist TEST=Linux desktop

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updated with message #2. #

Patch Set 3 : Updated a comment. #

Patch Set 4 : Forgot POTFILES.skip #

Patch Set 5 : Build bindings before engine. #

Patch Set 6 : Updated with the latest master. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -46 lines) Patch
M Makefile.am View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M autogen.sh View 1 1 chunk +4 lines, -1 line 0 comments Download
M bus/Makefile.am View 1 1 chunk +2 lines, -0 lines 0 comments Download
M configure.ac View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
M po/POTFILES.in View 1 chunk +46 lines, -41 lines 0 comments Download
A po/POTFILES.skip View 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M src/Makefile.am View 2 chunks +6 lines, -2 lines 0 comments Download
M ui/gtk3/Makefile.am View 1 3 chunks +7 lines, -1 line 2 comments Download

Messages

Total messages: 10
fujiwara
I fixed several build errors in make dist. # ./autogen.sh # make distcheck make[1]: Enter ...
12 years ago (2012-03-03 18:11:44 UTC) #1
Peng
https://codereview.appspot.com/5730046/diff/1/autogen.sh File autogen.sh (right): https://codereview.appspot.com/5730046/diff/1/autogen.sh#newcode26 autogen.sh:26: ACLOCAL_FLAGS="$ACLOCAL_FLAGS -I m4" REQUIRED_AUTOMAKE_VERSION=1.10 CFLAGS="-Wall -Werror $CFLAGS" . gnome-autogen.sh ...
12 years ago (2012-03-04 01:32:12 UTC) #2
fujiwara
On 2012/03/04 01:32:12, Peng wrote: > https://codereview.appspot.com/5730046/diff/1/autogen.sh > File autogen.sh (right): > > https://codereview.appspot.com/5730046/diff/1/autogen.sh#newcode26 > ...
12 years ago (2012-03-04 07:41:42 UTC) #3
Peng
lgtm
12 years ago (2012-03-04 15:19:42 UTC) #4
Daiki Ueno
https://codereview.appspot.com/5730046/diff/4005/ui/gtk3/Makefile.am File ui/gtk3/Makefile.am (right): https://codereview.appspot.com/5730046/diff/4005/ui/gtk3/Makefile.am#newcode111 ui/gtk3/Makefile.am:111: $(ibus_ui_gtk3_vala_cfiles) \ What's the intention of this? If you ...
12 years ago (2012-03-05 01:42:20 UTC) #5
fujiwara
On 2012/03/05 01:42:20, Daiki Ueno wrote: > https://codereview.appspot.com/5730046/diff/4005/ui/gtk3/Makefile.am > File ui/gtk3/Makefile.am (right): > > https://codereview.appspot.com/5730046/diff/4005/ui/gtk3/Makefile.am#newcode111 ...
12 years ago (2012-03-05 02:27:53 UTC) #6
fujiwara
On 2012/03/05 02:27:53, fujiwara wrote: > On 2012/03/05 01:42:20, Daiki Ueno wrote: > > https://codereview.appspot.com/5730046/diff/4005/ui/gtk3/Makefile.am ...
12 years ago (2012-03-05 02:28:48 UTC) #7
Peng
https://codereview.appspot.com/5730046/diff/4005/ui/gtk3/Makefile.am File ui/gtk3/Makefile.am (right): https://codereview.appspot.com/5730046/diff/4005/ui/gtk3/Makefile.am#newcode111 ui/gtk3/Makefile.am:111: $(ibus_ui_gtk3_vala_cfiles) \ On 2012/03/05 01:42:20, Daiki Ueno wrote: > ...
12 years ago (2012-03-05 02:58:35 UTC) #8
fujiwara
On 2012/03/05 02:58:35, Peng wrote: > https://codereview.appspot.com/5730046/diff/4005/ui/gtk3/Makefile.am > File ui/gtk3/Makefile.am (right): > > https://codereview.appspot.com/5730046/diff/4005/ui/gtk3/Makefile.am#newcode111 > ...
12 years ago (2012-03-05 03:11:20 UTC) #9
fujiwara
12 years ago (2012-03-05 03:28:11 UTC) #10
On 2012/03/05 03:11:20, fujiwara wrote:
> On 2012/03/05 02:58:35, Peng wrote:
> > https://codereview.appspot.com/5730046/diff/4005/ui/gtk3/Makefile.am
> > File ui/gtk3/Makefile.am (right):
> > 
> >
>
https://codereview.appspot.com/5730046/diff/4005/ui/gtk3/Makefile.am#newcode111
> > ui/gtk3/Makefile.am:111: $(ibus_ui_gtk3_vala_cfiles) \
> > On 2012/03/05 01:42:20, Daiki Ueno wrote:
> > > What's the intention of this?  If you really want to remove all vala
> generated
> > > *.c files on "make clean", it might make sense.  However, if you just
don't
> > want
> > > to include them in tarballs, it won't work, like files generated with
> > > flex/bison:
> > > 
> > > $ tar tf ibus-1.4.99.20120305.tar.gz | grep "ui/gtk3/.*.c$"
> > > ibus-1.4.99.20120305/ui/gtk3/iconwidget.c
> > > ibus-1.4.99.20120305/ui/gtk3/panel.c
> > > ...
> > > 
> > > I think this part could be reverted because:
> > > * no other projects using vala do that
> > > * developers can simply "make maintainer-clean" to remove *.c files
> > > * packagers can simply "touch ui/gtk3/*vala.stamp" to recompile vala
> > 
> > Sorry. I didn't notice this change. I think the generated c source files
> should
> > be included in release tarball. So Linux distribution maintainers does not
> need
> > install vala in their build environments.
> 
> If the C files need to be included in the tarball, probably
> 'makemaintainer-clean' makes sense.

OK, I reverted the change of ui/gtk3/Makefile.am in CL #5731060 .
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b