Issue 5729052: code review 5729052: doc: change menu, tweak front page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5729052: code review 5729052: doc: change menu, tweak front page (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by adg

Modified:
13 years ago

Reviewers:

CC:
golang-dev, Kyle E. Lemons, r

Visibility:
Public.

Patch Set 2 : diff -r eaff644d6377 https://code.google.com/p/go #

Created: 13 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+34 lines, -33 lines)			Patch
doc/root.html	View	3 chunks	+22 lines, -22 lines	0 comments	Download
doc/style.css	View	3 chunks	+7 lines, -7 lines	0 comments	Download
lib/godoc/godoc.html	View	1 chunk	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

13 years ago (2012-03-03 22:40:10 UTC) #1

Kyle E. Lemons

http://codereview.appspot.com/5729052/diff/1/lib/godoc/godoc.html File lib/godoc/godoc.html (left): http://codereview.appspot.com/5729052/diff/1/lib/godoc/godoc.html#oldcode23 lib/godoc/godoc.html:23: <a href="/doc/">Learn</a> I kinda liked "Learn" because it was ...

13 years ago (2012-03-03 23:04:52 UTC) #2

Kyle E. Lemons

http://codereview.appspot.com/5729052/diff/1/lib/godoc/godoc.html File lib/godoc/godoc.html (right): http://codereview.appspot.com/5729052/diff/1/lib/godoc/godoc.html#newcode24 lib/godoc/godoc.html:24: <a href="/ref/">References</a> On 2012/03/03 23:04:52, Kyle E. Lemons wrote: ...

13 years ago (2012-03-03 23:06:26 UTC) #3

LGTM http://codereview.appspot.com/5729052/diff/1/doc/root.html File doc/root.html (right): http://codereview.appspot.com/5729052/diff/1/doc/root.html#newcode45 doc/root.html:45: Binary distributions available for<br> should there be a ...

13 years ago (2012-03-04 23:28:38 UTC) #4

adg

13 years ago (2012-03-04 23:34:27 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=74b1429f9cab ***

doc: change menu, tweak front page

R=golang-dev, kyle, r
CC=golang-dev
http://codereview.appspot.com/5729052

http://codereview.appspot.com/5729052/diff/1/doc/root.html
File doc/root.html (right):

http://codereview.appspot.com/5729052/diff/1/doc/root.html#newcode45
doc/root.html:45: Binary distributions available for<br>
On 2012/03/04 23:28:38, r wrote:
> should there be a link here?

The two divs are surrounded by a link

Expand All Messages | Collapse All Messages