Correct a small error in the regex used for name validation

Correct a small error in the regex used for name validation

[damith, 2014-02-05 09:37:39]

https://codereview.appspot.com/57290044/diff/1/src/main/java/teammates/common...
File src/main/java/teammates/common/util/FieldValidator.java (right):

https://codereview.appspot.com/57290044/diff/1/src/main/java/teammates/common...
src/main/java/teammates/common/util/FieldValidator.java:267: private static
final String REGEX_NAME = "^[\\p{IsL}\\p{IsN}][^|%]*+$";
How come there is no corresponding change in test cases? :-p

[Oo Theong Siang, 2014-02-05 09:48:09]

https://codereview.appspot.com/57290044/diff/1/src/main/java/teammates/common...
File src/main/java/teammates/common/util/FieldValidator.java (right):

https://codereview.appspot.com/57290044/diff/1/src/main/java/teammates/common...
src/main/java/teammates/common/util/FieldValidator.java:267: private static
final String REGEX_NAME = "^[\\p{IsL}\\p{IsN}][^|%]*+$";
Actually the error doesn't affect the validation as there is previous checking
done by Character.isLetterOrDigit() which catch the error before the regex
validation.
So there is no special change in test case. Or I have to specifically test for
the presence of '}' using another test case?

On 2014/02/05 09:37:39, damith wrote:
> How come there is no corresponding change in test cases? :-p

[damith, 2014-02-05 09:52:31]

On 2014/02/05 09:48:09, Oo Theong Siang wrote:
>
https://codereview.appspot.com/57290044/diff/1/src/main/java/teammates/common...
> File src/main/java/teammates/common/util/FieldValidator.java (right):
> 
>
https://codereview.appspot.com/57290044/diff/1/src/main/java/teammates/common...
> src/main/java/teammates/common/util/FieldValidator.java:267: private static
> final String REGEX_NAME = "^[\\p{IsL}\\p{IsN}][^|%]*+$";
> Actually the error doesn't affect the validation as there is previous checking
> done by Character.isLetterOrDigit() which catch the error before the regex
> validation.
> So there is no special change in test case. Or I have to specifically test for
> the presence of '}' using another test case?
> 
> On 2014/02/05 09:37:39, damith wrote:
> > How come there is no corresponding change in test cases? :-p

If you could do behavior change in the code without modifying a test case, most
likely we don't have good coverage of the code. If that is the case, we need to
add more test cases.

[Oo Theong Siang, 2014-02-05 10:24:19]

On 2014/02/05 09:52:31, damith wrote:
> On 2014/02/05 09:48:09, Oo Theong Siang wrote:
> >
>
https://codereview.appspot.com/57290044/diff/1/src/main/java/teammates/common...
> > File src/main/java/teammates/common/util/FieldValidator.java (right):
> > 
> >
>
https://codereview.appspot.com/57290044/diff/1/src/main/java/teammates/common...
> > src/main/java/teammates/common/util/FieldValidator.java:267: private static
> > final String REGEX_NAME = "^[\\p{IsL}\\p{IsN}][^|%]*+$";
> > Actually the error doesn't affect the validation as there is previous
checking
> > done by Character.isLetterOrDigit() which catch the error before the regex
> > validation.
> > So there is no special change in test case. Or I have to specifically test
for
> > the presence of '}' using another test case?
> > 
> > On 2014/02/05 09:37:39, damith wrote:
> > > How come there is no corresponding change in test cases? :-p
> 
> If you could do behavior change in the code without modifying a test case,
most
> likely we don't have good coverage of the code. If that is the case, we need
to
> add more test cases.

[damith, 2014-02-05 10:35:41]

https://codereview.appspot.com/57290044/diff/1/src/main/java/teammates/common...
File src/main/java/teammates/common/util/FieldValidator.java (right):

https://codereview.appspot.com/57290044/diff/1/src/main/java/teammates/common...
src/main/java/teammates/common/util/FieldValidator.java:267: private static
final String REGEX_NAME = "^[\\p{IsL}\\p{IsN}][^|%]*+$";
write a test case just to check the regex. It could have code like this.
e.g.
assertTrue(isRegexMatching(regex, "matchingString");
assertFalse(isRegexMatching(regex, "nonMatchingString");