Issue 5728066: NetHttpResponse.getStatusCode() should return 0 not -1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5728066: NetHttpResponse.getStatusCode() should return 0 not -1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by yanivi

Modified:
13 years, 9 months ago

Reviewers:
rmistry

Base URL:
https://google-http-java-client.googlecode.com/hg/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : hg status #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+159 lines, -13 lines)			Patch
M	google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java	View		2 chunks	+9 lines, -3 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/javanet/NetHttpResponse.java	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/testing/http/MockLowLevelHttpResponse.java	View		3 chunks	+4 lines, -6 lines	0 comments	Download
M	google-http-client/src/test/java/com/google/api/client/http/HttpResponseExceptionTest.java	View	1	2 chunks	+51 lines, -2 lines	0 comments	Download
A	google-http-client/src/test/java/com/google/api/client/http/javanet/NetHttpResponseTest.java	View		1 chunk	+62 lines, -0 lines	0 comments	Download
A	google-http-client/src/test/java/com/google/api/client/http/javanet/NetHttpTransportTest.java	View		1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rmistry

13 years, 9 months ago (2012-03-06 15:39:25 UTC) #2

LGTM

http://codereview.appspot.com/5728066/diff/1/google-http-client/src/test/java...
File
google-http-client/src/test/java/com/google/api/client/http/HttpResponseExceptionTest.java
(right):

http://codereview.appspot.com/5728066/diff/1/google-http-client/src/test/java...
google-http-client/src/test/java/com/google/api/client/http/HttpResponseExceptionTest.java:59:
@Override
@Override spacing is off in this class.

Expand All Messages | Collapse All Messages