Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(29)

Issue 5728055: code review 5728055: doc: add command docs page, canonicalize reference paths (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by adg
Modified:
9 years, 9 months ago
Reviewers:
CC:
golang-dev, Kyle E. Lemons, r
Visibility:
Public.

Description

doc: add command docs page, canonicalize reference paths

Patch Set 1 #

Patch Set 2 : diff -r cfe083cbdb66 https://code.google.com/p/go #

Total comments: 4

Patch Set 3 : diff -r cfe083cbdb66 https://code.google.com/p/go #

Total comments: 4

Patch Set 4 : diff -r 74b1429f9cab https://code.google.com/p/go #

Patch Set 5 : diff -r 74b1429f9cab https://code.google.com/p/go #

Total comments: 2

Patch Set 6 : diff -r 665a55edc8c4 https://code.google.com/p/go #

Total comments: 2

Patch Set 7 : diff -r 54200b94f009 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -19 lines) Patch
M doc/debugging_with_gdb.html View 1 chunk +2 lines, -1 line 0 comments Download
M doc/effective_go.html View 1 chunk +1 line, -1 line 0 comments Download
M doc/effective_go.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M doc/go_faq.html View 3 chunks +3 lines, -3 lines 0 comments Download
M doc/go_mem.html View 1 chunk +2 lines, -1 line 0 comments Download
M doc/go_spec.html View 1 chunk +2 lines, -1 line 0 comments Download
M doc/reference.html View 1 2 2 chunks +23 lines, -11 lines 0 comments Download
A doc/reference-cmd.html View 1 2 3 4 5 6 1 chunk +84 lines, -0 lines 0 comments Download

Messages

Total messages: 11
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 9 months ago (2012-03-03 22:57:03 UTC) #1
Kyle E. Lemons
LGTM http://codereview.appspot.com/5728055/diff/3001/doc/reference-cmd.html File doc/reference-cmd.html (right): http://codereview.appspot.com/5728055/diff/3001/doc/reference-cmd.html#newcode70 doc/reference-cmd.html:70: This is an abridged list. See the <a ...
9 years, 9 months ago (2012-03-03 23:14:44 UTC) #2
adg
http://codereview.appspot.com/5728055/diff/3001/doc/reference-cmd.html File doc/reference-cmd.html (right): http://codereview.appspot.com/5728055/diff/3001/doc/reference-cmd.html#newcode70 doc/reference-cmd.html:70: This is an abridged list. See the <a href="/cmd/">full ...
9 years, 9 months ago (2012-03-03 23:19:29 UTC) #3
r
http://codereview.appspot.com/5728055/diff/6001/doc/reference-cmd.html File doc/reference-cmd.html (right): http://codereview.appspot.com/5728055/diff/6001/doc/reference-cmd.html#newcode28 doc/reference-cmd.html:28: <td style="width: auto">Fix finds Go programs that use old ...
9 years, 9 months ago (2012-03-04 23:36:51 UTC) #4
adg
http://codereview.appspot.com/5728055/diff/6001/doc/reference-cmd.html File doc/reference-cmd.html (right): http://codereview.appspot.com/5728055/diff/6001/doc/reference-cmd.html#newcode28 doc/reference-cmd.html:28: <td style="width: auto">Fix finds Go programs that use old ...
9 years, 9 months ago (2012-03-05 00:04:32 UTC) #5
adg
PTAL
9 years, 9 months ago (2012-03-05 03:27:11 UTC) #6
r
https://codereview.appspot.com/5728055/diff/1026/doc/reference-cmd.html File doc/reference-cmd.html (right): https://codereview.appspot.com/5728055/diff/1026/doc/reference-cmd.html#newcode39 doc/reference-cmd.html:39: <td>Go is a tool for managing Go source code.</td> ...
9 years, 9 months ago (2012-03-05 03:31:07 UTC) #7
adg
https://codereview.appspot.com/5728055/diff/1026/doc/reference-cmd.html File doc/reference-cmd.html (right): https://codereview.appspot.com/5728055/diff/1026/doc/reference-cmd.html#newcode39 doc/reference-cmd.html:39: <td>Go is a tool for managing Go source code.</td> ...
9 years, 9 months ago (2012-03-05 04:04:29 UTC) #8
adg
Hello golang-dev@googlegroups.com, kyle@kylelemons.net, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 9 months ago (2012-03-05 04:04:47 UTC) #9
r
LGTM http://codereview.appspot.com/5728055/diff/5010/doc/reference-cmd.html File doc/reference-cmd.html (right): http://codereview.appspot.com/5728055/diff/5010/doc/reference-cmd.html#newcode23 doc/reference-cmd.html:23: It may be used to invoke the other ...
9 years, 9 months ago (2012-03-05 04:16:47 UTC) #10
adg
9 years, 9 months ago (2012-03-05 04:30:32 UTC) #11
*** Submitted as http://code.google.com/p/go/source/detail?r=9f5294988ba7 ***

doc: add command docs page, canonicalize reference paths

R=golang-dev, kyle, r
CC=golang-dev
http://codereview.appspot.com/5728055

http://codereview.appspot.com/5728055/diff/5010/doc/reference-cmd.html
File doc/reference-cmd.html (right):

http://codereview.appspot.com/5728055/diff/5010/doc/reference-cmd.html#newcode23
doc/reference-cmd.html:23: It may be used to invoke the other commands listed
below.
On 2012/03/05 04:16:48, r wrote:
> Besides compiling and running Go programs, the go command is also used to
> invoke....

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b