Issue 5727056: code review 5727056: doc/progs: update for go 1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5727056: code review 5727056: doc/progs: update for go 1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by r

Modified:
13 years ago

Reviewers:
rsc

CC:
golang-dev, dsymonds, r2

Visibility:
Public.

Description

doc/progs: update for go 1 Fixes issue 3076.

Patch Set 2 : diff -r e9202b52e2eb https://code.google.com/p/go/ #

Total comments: 2

Patch Set 3 : diff -r e9202b52e2eb https://code.google.com/p/go/ #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -40 lines)			Patch
M	doc/go1.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	doc/progs/error.go	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	doc/progs/go1.go	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
M	doc/progs/run	View	1	1 chunk	+22 lines, -36 lines	0 comments	Download
M	doc/progs/slices.go	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/run.bash	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years ago (2012-03-05 01:06:27 UTC) #1

dsymonds

LGTM http://codereview.appspot.com/5727056/diff/2002/doc/progs/go1.go File doc/progs/go1.go (right): http://codereview.appspot.com/5727056/diff/2002/doc/progs/go1.go#newcode185 doc/progs/go1.go:185: fmt.Printf("Sleeping for %.3fs", delta.Seconds()) this needs a \n ...

13 years ago (2012-03-05 01:13:29 UTC) #2

On Mar 5, 2012, at 12:13 PM, dsymonds@golang.org wrote: > LGTM > > > http://codereview.appspot.com/5727056/diff/2002/doc/progs/go1.go ...

13 years ago (2012-03-05 01:48:11 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=2554519cca15 *** doc/progs: update for go 1 Fixes issue 3076. R=golang-dev, dsymonds, ...

13 years ago (2012-03-05 01:49:38 UTC) #4

LGTM

Expand All Messages | Collapse All Messages