Issue 5727054: code review 5727054: net: move MAC address parser into distinct file

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5727054: code review 5727054: net: move MAC address parser into distinct file (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by mikio

Modified:
13 years ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

net: move MAC address parser into distinct file

Patch Set 1 : diff -r a2275531cfe0 https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r a2275531cfe0 https://go.googlecode.com/hg/ #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -322 lines)			Patch
M	src/pkg/net/interface.go	View	2 chunks	+1 line, -76 lines	0 comments	Download
M	src/pkg/net/interface_test.go	View	2 chunks	+0 lines, -45 lines	0 comments	Download
M	src/pkg/net/mac.go	View	3 chunks	+1 line, -114 lines	0 comments	Download
M	src/pkg/net/mac_test.go	View	1 chunk	+0 lines, -87 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years ago (2012-03-04 11:08:02 UTC) #1

bradfitz

LGTM On Sun, Mar 4, 2012 at 10:08 PM, <mikioh.mikioh@gmail.com> wrote: > Reviewers: golang-dev_googlegroups.com, > ...

13 years ago (2012-03-04 16:37:01 UTC) #2

mikio

13 years ago (2012-03-04 22:42:15 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=eaff644d6377 ***

net: move MAC address parser into distinct file

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5727054

Expand All Messages | Collapse All Messages