Issue 5726048: [PDF] Fix name objects containing characters > 0x80 and add a test.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5726048: [PDF] Fix name objects containing characters > 0x80 and add a test. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by Steve VanDeBogart

Modified:
12 years, 4 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

[PDF] Fix name objects containing characters > 0x80 and add a test. This fixes chrome bug http://crbug.com/115258 Committed: https://code.google.com/p/skia/source/detail?r=3319

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comments #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	src/pdf/SkPDFTypes.cpp	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
	M	tests/PDFPrimitivesTest.cpp	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

reed1

12 years, 4 months ago (2012-03-05 13:29:06 UTC) #2

lgtm -- w/ possible comments

https://codereview.appspot.com/5726048/diff/1/src/pdf/SkPDFTypes.cpp
File src/pdf/SkPDFTypes.cpp (right):

https://codereview.appspot.com/5726048/diff/1/src/pdf/SkPDFTypes.cpp#newcode299
src/pdf/SkPDFTypes.cpp:299: result.append("#");
// mask with 0xFF to avoid sign-extension to negative when char is signed.

https://codereview.appspot.com/5726048/diff/1/tests/PDFPrimitivesTest.cpp
File tests/PDFPrimitivesTest.cpp (left):

https://codereview.appspot.com/5726048/diff/1/tests/PDFPrimitivesTest.cpp#old...
tests/PDFPrimitivesTest.cpp:277: 
// Test that we safely handle chars with the high-bit set, which have to be
handled separately (as hex) from 7bit chars.

Expand All Messages | Collapse All Messages