Issue 5724045: code review 5724045: cmd/go: avoid repeated include dirs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5724045: code review 5724045: cmd/go: avoid repeated include dirs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by remyoudompheng

Modified:
13 years ago

Reviewers:

CC:
golang-dev, rsc, remy_archlinux.org

Visibility:
Public.

Description

cmd/go: avoid repeated include dirs. Fixes issue 3171.

Patch Set 1 #

Patch Set 2 : diff -r 50adb6a9e76c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 50adb6a9e76c https://go.googlecode.com/hg/ #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/go/build.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/

13 years ago (2012-03-02 09:42:34 UTC) #1

rsc

13 years ago (2012-03-02 16:31:16 UTC) #3

*** Submitted as 85bd2ea73846 ***

cmd/go: avoid repeated include dirs.

Fixes issue 3171.

R=golang-dev, rsc
CC=golang-dev, remy
http://codereview.appspot.com/5724045

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages