Issue 5720068: Revert Gdk.DeviceManager.list_devices to work with vala 0.15

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5720068: Revert Gdk.DeviceManager.list_devices to work with vala 0.15 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by fujiwara

Modified:
12 years, 1 month ago

Reviewers:
shawn.p.huang

CC:
shawn.p.huang_gmail.com

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Revert Gdk.DeviceManager.list_devices to work with vala 0.15 Fixed a build error in ui/gtk3 with vala 0.15 TEST=Linux desktop

Patch Set 2 : Updated with message #2. #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	ui/gtk3/switcher.vala	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

fujiwara

Reading the vala change, http://git.gnome.org/browse/vala/commit/?id=9da6293119d584e4a759ed07bd6c54dea442d939 , it seems the build was changed from gi to ...

12 years, 1 month ago (2012-03-03 18:04:06 UTC) #1

Peng

https://codereview.appspot.com/5720068/diff/1/ui/gtk3/switcher.vala File ui/gtk3/switcher.vala (right): https://codereview.appspot.com/5720068/diff/1/ui/gtk3/switcher.vala#newcode68 ui/gtk3/switcher.vala:68: #if ENABLE_VALA_0_15 http://live.gnome.org/Vala/Manual/Preprocessor seems you could check VALA_1_5 here?

12 years, 1 month ago (2012-03-04 01:40:28 UTC) #2

fujiwara

On 2012/03/04 01:40:28, Peng wrote: > https://codereview.appspot.com/5720068/diff/1/ui/gtk3/switcher.vala > File ui/gtk3/switcher.vala (right): > > https://codereview.appspot.com/5720068/diff/1/ui/gtk3/switcher.vala#newcode68 > ...

12 years, 1 month ago (2012-03-04 07:29:47 UTC) #3

lgtm

Expand All Messages | Collapse All Messages