Issue 57170049: Add --nologo flag to Syzygy tool command line parsing to allow for fully silent execution.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 57170049: Add --nologo flag to Syzygy tool command line parsing to allow for fully silent execution. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by Robert

Modified:
10 years, 10 months ago

Reviewers:
chrisha

CC:
sawbuck-changes_googlegroups.com

Base URL:
http://sawbuck.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add --nologo flag to Syzygy tool command line parsing to allow for fully silent execution. BUG=88 R=chrisha@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=2029

Patch Set 2 : #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	syzygy/common/application_impl.h	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

chrisha

lgtm with a nit https://codereview.appspot.com/57170049/diff/1/syzygy/common/application_impl.h File syzygy/common/application_impl.h (right): https://codereview.appspot.com/57170049/diff/1/syzygy/common/application_impl.h#newcode44 syzygy/common/application_impl.h:44: if (!command_line_->HasSwitch("nologo")) { I have ...

10 years, 10 months ago (2014-02-10 14:26:59 UTC) #2

Robert

https://codereview.appspot.com/57170049/diff/1/syzygy/common/application_impl.h File syzygy/common/application_impl.h (right): https://codereview.appspot.com/57170049/diff/1/syzygy/common/application_impl.h#newcode44 syzygy/common/application_impl.h:44: if (!command_line_->HasSwitch("nologo")) { On 2014/02/10 14:27:00, chrisha wrote: > ...

10 years, 10 months ago (2014-02-10 14:37:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r2029.

Expand All Messages | Collapse All Messages