Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(84)

Issue 57170046: Add leniency in taming for better Google Visualization API support. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by kpreid2
Modified:
12 years, 1 month ago
Reviewers:
ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Loading google.visualization with options such as {packages:['orgchart']} will result in a stub "google.visualization.PieChart" which is not a function, causing markCtor to fail. To avoid failures like this, skip taming any object which is expected to be a ctor but is not a function. Supporting changes: In the test server, request disabling of browser XSS protection. This sometimes interferes with the generic-host-page since it evaluates scripts specified in the URL, and could plausibly hide an actual unsandboxed execution bug in Caja from the tests. @r5661

Patch Set 1 #

Patch Set 2 : Add leniency in taming for better Google Visualization API support. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
src/com/google/caja/apitaming/cajaTamingGoogleLoader.js View 1 chunk +8 lines, -0 lines 0 comments Download
tests/com/google/caja/util/LocalServer.java View 3 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 3
kpreid2
12 years, 1 month ago (2014-02-07 01:18:24 UTC) #1
kpreid2
Loading google.visualization with options such as {packages:['orgchart']} will result in a stub "google.visualization.PieChart" which is ...
12 years, 1 month ago (2014-02-07 01:19:05 UTC) #2
ihab.awad
12 years, 1 month ago (2014-02-07 05:54:32 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b