code review 5714059: cmd/go: fixes for gccgo.

src/cmd/go/test.go

 // Copyright 2011 The Go Authors.  All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package main
 
 import (
         "bytes"
         "fmt"
         "go/ast"
@@ skipping 406 matching lines @@
         // and then repeat the import path there.  We tell the
         // compiler and linker to look in that _test directory first.
         //
         // That is, if the package under test is unicode/utf8,
         // then the normal place to write the package archive is
         // $WORK/unicode/utf8.a, but we write the test package archive to
         // $WORK/unicode/utf8/_test/unicode/utf8.a.
         // We write the external test package archive to
         // $WORK/unicode/utf8/_test/unicode/utf8_test.a.
         testDir := filepath.Join(b.work, filepath.FromSlash(p.ImportPath+"/_test"))
-        ptestObj := buildToolchain.pkgpath(testDir, p, false)
+        ptestObj := buildToolchain.pkgpath(testDir, p)
 
         // Create the directory for the .a files.
         ptestDir, _ := filepath.Split(ptestObj)
         if err := b.mkdir(ptestDir); err != nil {
                 return nil, nil, nil, err
         }
         if err := writeTestmain(filepath.Join(testDir, "_testmain.go"), p); err != nil {
                 return nil, nil, nil, err
         }
 
@@ skipping 38 matching lines @@
                         Imports:    p.XTestImports,
                         build: &build.Package{
                                 ImportPos: p.build.XTestImportPos,
                         },
                         imports: append(ximports, ptest),
                         pkgdir:  testDir,
                         fake:    true,
                 }
                 a := b.action(modeBuild, modeBuild, pxtest)
                 a.objdir = testDir + string(filepath.Separator)
-                a.objpkg = buildToolchain.pkgpath(testDir, pxtest, false)
+                a.objpkg = buildToolchain.pkgpath(testDir, pxtest)
                 a.target = a.objpkg
         }
 
         // Action for building pkg.test.
         pmain = &Package{
                 Name:    "main",
                 Dir:     testDir,
                 GoFiles: []string{"_testmain.go"},
                 imports: []*Package{ptest},
                 build:   &build.Package{},
@@ skipping 292 matching lines @@
                 }
         }
         return matchRe.MatchString(str), nil
 }
 
 func main() {
         testing.Main(matchString, tests, benchmarks, examples)
 }
 
 `))