Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(188)

Issue 5713054: code review 5713054: doc: update go1 for html changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by adg
Modified:
13 years, 10 months ago
Reviewers:
CC:
golang-dev, rsc, r
Visibility:
Public.

Description

doc: update go1 for html changes

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r aa80d27aef25 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 115ebe8a3935 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M doc/go1.html View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M doc/go1.tmpl View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg
13 years, 10 months ago (2012-03-01 23:04:49 UTC) #1
rsc
s/E/e/
13 years, 10 months ago (2012-03-01 23:05:53 UTC) #2
r
http://codereview.appspot.com/5713054/diff/1/doc/go1.tmpl File doc/go1.tmpl (right): http://codereview.appspot.com/5713054/diff/1/doc/go1.tmpl#newcode577 doc/go1.tmpl:577: <li><code>html</code> (Except for the <code>EscapeString</code> and s/E/e/ might put ...
13 years, 10 months ago (2012-03-01 23:13:25 UTC) #3
adg
Hello golang-dev@googlegroups.com, rsc@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 10 months ago (2012-03-02 00:45:33 UTC) #4
r
LGTM
13 years, 10 months ago (2012-03-02 00:46:16 UTC) #5
adg
13 years, 10 months ago (2012-03-02 00:52:54 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=a1838a690f0a ***

doc: update go1 for html changes

R=golang-dev, rsc, r
CC=golang-dev
http://codereview.appspot.com/5713054

http://codereview.appspot.com/5713054/diff/1/doc/go1.tmpl
File doc/go1.tmpl (right):

http://codereview.appspot.com/5713054/diff/1/doc/go1.tmpl#newcode577
doc/go1.tmpl:577: <li><code>html</code> (Except for the
<code>EscapeString</code> and
On 2012/03/01 23:13:25, r wrote:
> s/E/e/
> might put * here and make it a footnote.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b